You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/01 09:42:35 UTC

[GitHub] [arrow] vertexclique commented on a change in pull request #7873: ARROW-9608: [Rust] Leaner feature gating for arrow in parquet

vertexclique commented on a change in pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#discussion_r463945019



##########
File path: rust/parquet/Cargo.toml
##########
@@ -49,7 +49,6 @@ brotli = "3.3"
 flate2 = "1.0"
 lz4 = "1.23"
 zstd = "0.5"
-arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" }

Review comment:
       yes, because it is already a dependency in `arrow.rs`, using `super::*;` export in test modules will make it use the actual dependency exports of the arrow (which has been done already seems like). Tests had passed locally with no change and it passed here. I see it as good improvement tbh :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org