You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Greg Stein <gs...@lyra.org> on 2001/08/02 22:31:00 UTC

Re: cvs commit: apr-util/xml/expat buildconf buildconf.sh

On Wed, Aug 01, 2001 at 08:47:13PM -0000, jerenkrantz@apache.org wrote:
> jerenkrantz    01/08/01 13:47:13
> 
>   Modified:    .        .cvsignore CHANGES configure.in
>                build    apu-conf.m4
>   Added:       .        buildconf
>                xml/expat buildconf
>   Removed:     .        buildconf.sh
>                xml/expat buildconf.sh
>...
>   - Removes libtool generation in apr-util.  rbb's recent commit made it so
>     that we would use APR's libtool, but he didn't remove the generation of
>     it.  Expat still generates a libtool, but I may remove it from there
>     (but I am leery of branching too much from the official Expat version).

Changing the name of that file will make it much more difficult to apply
fixes back and forth between the two. Tossing libtool might not be too bad,
but it does seem like a marginal optimization -- it will only be used when
somebody doesn't have an expat on their system.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: cvs commit: apr-util/xml/expat buildconf buildconf.sh

Posted by Greg Stein <gs...@lyra.org>.
On Thu, Aug 02, 2001 at 01:58:04PM -0700, Justin Erenkrantz wrote:
> On Thu, Aug 02, 2001 at 01:31:00PM -0700, Greg Stein wrote:
> > On Wed, Aug 01, 2001 at 08:47:13PM -0000, jerenkrantz@apache.org wrote:
> > > jerenkrantz    01/08/01 13:47:13
> > > 
> > >   Modified:    .        .cvsignore CHANGES configure.in
> > >                build    apu-conf.m4
> > >   Added:       .        buildconf
> > >                xml/expat buildconf
> > >   Removed:     .        buildconf.sh
> > >                xml/expat buildconf.sh
> > >...
> > >   - Removes libtool generation in apr-util.  rbb's recent commit made it so
> > >     that we would use APR's libtool, but he didn't remove the generation of
> > >     it.  Expat still generates a libtool, but I may remove it from there
> > >     (but I am leery of branching too much from the official Expat version).
> > 
> > Changing the name of that file will make it much more difficult to apply
> > fixes back and forth between the two. Tossing libtool might not be too bad,
> > but it does seem like a marginal optimization -- it will only be used when
> > somebody doesn't have an expat on their system.
> 
> Did we add the buildconf.sh or is that a part of the official expat
> repository?

Part of the official repository. I put it there :-)

>...
> I don't really plan on removing libtool from expat.  It was just a 
> thought.  We seem to have out-of-date config.guess and libtool in 
> our bundled expat which causes problem with newer OSes (Darwin?).  

There are a lot of build/config fixes that I need to do to Expat so that
another Expat release can be made (1.95.2 was done last week; this month
will see a 1.95.3). Part of that will be to upgrade the libtool in there,
and to integrate changes back/forth between our copy and the official one.
Our copy has some good work in the build/config that can migrate over to the
official Expat (the ASF is good at that part :-).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: cvs commit: apr-util/xml/expat buildconf buildconf.sh

Posted by Justin Erenkrantz <je...@ebuilt.com>.
On Thu, Aug 02, 2001 at 01:31:00PM -0700, Greg Stein wrote:
> On Wed, Aug 01, 2001 at 08:47:13PM -0000, jerenkrantz@apache.org wrote:
> > jerenkrantz    01/08/01 13:47:13
> > 
> >   Modified:    .        .cvsignore CHANGES configure.in
> >                build    apu-conf.m4
> >   Added:       .        buildconf
> >                xml/expat buildconf
> >   Removed:     .        buildconf.sh
> >                xml/expat buildconf.sh
> >...
> >   - Removes libtool generation in apr-util.  rbb's recent commit made it so
> >     that we would use APR's libtool, but he didn't remove the generation of
> >     it.  Expat still generates a libtool, but I may remove it from there
> >     (but I am leery of branching too much from the official Expat version).
> 
> Changing the name of that file will make it much more difficult to apply
> fixes back and forth between the two. Tossing libtool might not be too bad,
> but it does seem like a marginal optimization -- it will only be used when
> somebody doesn't have an expat on their system.

Did we add the buildconf.sh or is that a part of the official expat
repository?  If it is a part of expat, I'll revert back to 
buildconf.sh for xml/expat.  I'd like to keep apr-util as buildconf 
since that matches apr and httpd-2.0.

I don't really plan on removing libtool from expat.  It was just a 
thought.  We seem to have out-of-date config.guess and libtool in 
our bundled expat which causes problem with newer OSes (Darwin?).  
-- justin


Re: cvs commit: apr-util/xml/expat buildconf buildconf.sh

Posted by Cliff Woolley <cl...@yahoo.com>.
On Thu, 2 Aug 2001, Greg Stein wrote:

> (2) is flat out wrong: you need to "cvs rm" it so the "state" is correct
> within the file. It needs to be "dead" rather than just moved to the Attic.

Oops, yeah, what you said.  =-)

> And the technique is also prone to error. Even tho you remove the tags,
> checking out by date will create spurious files (i.e. the "new" file will
> appear in old checkouts).
>
> "cvs add" and "cvs rm" with a pointer in the new file to the old is the
> safest all around.

Whatever.  We've typically kept the history when we did this in the past,
but I don't much care.

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Re: cvs commit: apr-util/xml/expat buildconf buildconf.sh

Posted by Greg Stein <gs...@lyra.org>.
On Thu, Aug 02, 2001 at 04:56:45PM -0400, Cliff Woolley wrote:
>...
> BTW - The spiffy cool way to do file renames and get history preserved is
> as follows:
> 
> (1) copy the ,v file to its new name
> (2) move the old ,v file to the Attic
> (3) remove all tags from the new ,v file

No... that is borken.

(2) is flat out wrong: you need to "cvs rm" it so the "state" is correct
within the file. It needs to be "dead" rather than just moved to the Attic.

And the technique is also prone to error. Even tho you remove the tags,
checking out by date will create spurious files (i.e. the "new" file will
appear in old checkouts).

"cvs add" and "cvs rm" with a pointer in the new file to the old is the
safest all around.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: cvs commit: apr-util/xml/expat buildconf buildconf.sh

Posted by Cliff Woolley <cl...@yahoo.com>.
On Thu, 2 Aug 2001, Greg Stein wrote:

> On Wed, Aug 01, 2001 at 08:47:13PM -0000, jerenkrantz@apache.org wrote:
> > jerenkrantz    01/08/01 13:47:13
> >
> >   Modified:    .        .cvsignore CHANGES configure.in
> >                build    apu-conf.m4
> >   Added:       .        buildconf
> >                xml/expat buildconf
> >   Removed:     .        buildconf.sh
> >                xml/expat buildconf.sh
> >...
> >   - Removes libtool generation in apr-util.  rbb's recent commit made it so
> >     that we would use APR's libtool, but he didn't remove the generation of
> >     it.  Expat still generates a libtool, but I may remove it from there
> >     (but I am leery of branching too much from the official Expat version).
>
> Changing the name of that file will make it much more difficult to apply
> fixes back and forth between the two. Tossing libtool might not be too bad,
> but it does seem like a marginal optimization -- it will only be used when
> somebody doesn't have an expat on their system.

Yeah... I'm -0.5 for changing stuff like that in Expat.  Don't get me
wrong... ++1 for changing it in apr-util itself.  =-)

BTW - The spiffy cool way to do file renames and get history preserved is
as follows:

(1) copy the ,v file to its new name
(2) move the old ,v file to the Attic
(3) remove all tags from the new ,v file

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA