You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/09 08:12:51 UTC
[GitHub] [pulsar] zymap opened a new pull request #8876: (WIP) Add integration tests for package management service
zymap opened a new pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876
---
Master Issue: #8676
*Motivation*
Add integration tests for testing the whole package management service.
*Modifications*
- Add integration tests
- Fix some issue when startup the package management service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#issuecomment-742457990
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#discussion_r539336475
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
Review comment:
Thank you. I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#issuecomment-742375298
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#issuecomment-742355559
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#discussion_r539311538
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
Review comment:
what about naming this method` getPackagesReplicas() `?
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
- return Integer.parseInt(getProperty("numReplicas"));
+ return Integer.parseInt(getProperty("packagesReplicas"));
}
String getZkServers() {
- return getProperty("zkServers");
+ return getProperty("zookeeperServers");
Review comment:
what about naming this method getZookeeperServers() `?
##########
File path: pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorageConfiguration.java
##########
@@ -35,15 +35,15 @@
}
int getNumReplicas() {
- return Integer.parseInt(getProperty("numReplicas"));
+ return Integer.parseInt(getProperty("packagesReplicas"));
}
String getZkServers() {
- return getProperty("zkServers");
+ return getProperty("zookeeperServers");
}
String getLedgersRootPath() {
- return getProperty("ledgerRootPath");
+ return getProperty("packagesManagementLedgerRootPath");
Review comment:
what about naming this method `getPackagesManagementLedgerRootPath()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8876: Add integration tests for package management service
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8876:
URL: https://github.com/apache/pulsar/pull/8876#issuecomment-742238855
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org