You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <ja...@maven.org> on 2007/01/20 02:44:40 UTC
Re: svn commit: r498038 - in /maven/shared/trunk/maven-verifier/src/main/java/org/apache/maven/it/verifier: AbstractVerifier.java Verifier.java
-1
Roll that out.
Please ask was the rule we setup. Please adhere to it. You know that
I've been working on this stuff for months as I'm sure you watch the
commit logs and I posted about the problems with the ITs.
The verifier is not the place for the embedder.
The multiple invokers we have need to be collected, the multiple
verifiers need to be collected and the place the embedder is in the
final invoker. A testing tool being created from the a verifier and
invoker. If you want to help, then help us clean up the ITs first.
Jason.
On 19 Jan 07, at 5:26 PM 19 Jan 07, carlos@apache.org wrote:
> Author: carlos
> Date: Fri Jan 19 17:26:20 2007
> New Revision: 498038
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=498038
> Log:
> Creating a embedder verifier
>
> Added:
> maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> maven/it/verifier/AbstractVerifier.java
> - copied, changed from r498037, maven/shared/trunk/maven-
> verifier/src/main/java/org/apache/maven/it/verifier/Verifier.java
> Removed:
> maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> maven/it/verifier/Verifier.java
>
> Copied: maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> maven/it/verifier/AbstractVerifier.java (from r498037, maven/shared/
> trunk/maven-verifier/src/main/java/org/apache/maven/it/verifier/
> Verifier.java)
> URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-verifier/
> src/main/java/org/apache/maven/it/verifier/AbstractVerifier.java?
> view=diff&rev=498038&p1=maven/shared/trunk/maven-verifier/src/main/
> java/org/apache/maven/it/verifier/Verifier.java&r1=498037&p2=maven/
> shared/trunk/maven-verifier/src/main/java/org/apache/maven/it/
> verifier/AbstractVerifier.java&r2=498038
> ======================================================================
> ========
> --- maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> maven/it/verifier/Verifier.java (original)
> +++ maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> maven/it/verifier/AbstractVerifier.java Fri Jan 19 17:26:20 2007
> @@ -1,21 +1,24 @@
> package org.apache.maven.it.verifier;
>
> -import junit.framework.Assert;
> -import org.apache.maven.it.util.FileUtils;
> -import org.apache.maven.it.util.StringUtils;
> -import org.apache.maven.it.util.cli.CommandLineException;
> -import org.apache.maven.it.util.cli.CommandLineUtils;
> -import org.apache.maven.it.util.cli.Commandline;
> -import org.apache.maven.it.util.cli.StreamConsumer;
> -import org.apache.maven.it.util.cli.WriterStreamConsumer;
> -import org.xml.sax.InputSource;
> -import org.xml.sax.SAXException;
> -import org.xml.sax.SAXParseException;
> -import org.xml.sax.helpers.DefaultHandler;
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements. See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership. The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied. See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
>
> -import javax.xml.parsers.ParserConfigurationException;
> -import javax.xml.parsers.SAXParser;
> -import javax.xml.parsers.SAXParserFactory;
> import java.io.BufferedReader;
> import java.io.ByteArrayOutputStream;
> import java.io.File;
> @@ -41,13 +44,33 @@
> import java.util.Properties;
> import java.util.StringTokenizer;
>
> +import javax.xml.parsers.ParserConfigurationException;
> +import javax.xml.parsers.SAXParser;
> +import javax.xml.parsers.SAXParserFactory;
> +
> +import junit.framework.Assert;
> +
> +import org.apache.maven.it.VerificationException;
> +import org.apache.maven.it.Verifier;
> +import org.apache.maven.it.util.FileUtils;
> +import org.apache.maven.it.util.StringUtils;
> +import org.apache.maven.it.util.cli.CommandLineException;
> +import org.apache.maven.it.util.cli.CommandLineUtils;
> +import org.apache.maven.it.util.cli.Commandline;
> +import org.apache.maven.it.util.cli.StreamConsumer;
> +import org.apache.maven.it.util.cli.WriterStreamConsumer;
> +import org.xml.sax.InputSource;
> +import org.xml.sax.SAXException;
> +import org.xml.sax.SAXParseException;
> +import org.xml.sax.helpers.DefaultHandler;
> +
> /**
> * @author <a href="mailto:jason@maven.org">Jason van Zyl </a>
> * @author <a href="mailto:brett@apache.org">Brett Porter</a>
> * @version $Id$
> * @noinspection UseOfSystemOutOrSystemErr,RefusedBequest
> */
> -public class Verifier
> +public abstract class AbstractVerifier
> {
> private static final String LOG_FILENAME = "log.txt";
>
> @@ -74,13 +97,13 @@
>
> private boolean debug;
>
> - public Verifier( String basedir, String settingsFile )
> + public AbstractVerifier( String basedir, String settingsFile )
> throws VerificationException
> {
> this( basedir, settingsFile, false );
> }
>
> - public Verifier( String basedir, String settingsFile, boolean
> debug )
> + public AbstractVerifier( String basedir, String settingsFile,
> boolean debug )
> throws VerificationException
> {
> this.basedir = basedir;
> @@ -101,13 +124,13 @@
> findLocalRepo( settingsFile );
> }
>
> - public Verifier( String basedir )
> + public AbstractVerifier( String basedir )
> throws VerificationException
> {
> this( basedir, null );
> }
>
> - public Verifier( String basedir, boolean debug )
> + public AbstractVerifier( String basedir, boolean debug )
> throws VerificationException
> {
> this( basedir, null, debug );
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r498038 - in /maven/shared/trunk/maven-verifier/src/main/java/org/apache/maven/it/verifier: AbstractVerifier.java Verifier.java
Posted by Carlos Sanchez <ca...@apache.org>.
sorry about that, I was playing with it and committed just to keep
history for new files. No previous files have been changed. I'll throw
a new thread for details.
On 1/19/07, Jason van Zyl <ja...@maven.org> wrote:
> -1
>
> Roll that out.
>
> Please ask was the rule we setup. Please adhere to it. You know that
> I've been working on this stuff for months as I'm sure you watch the
> commit logs and I posted about the problems with the ITs.
>
> The verifier is not the place for the embedder.
>
> The multiple invokers we have need to be collected, the multiple
> verifiers need to be collected and the place the embedder is in the
> final invoker. A testing tool being created from the a verifier and
> invoker. If you want to help, then help us clean up the ITs first.
>
> Jason.
>
> On 19 Jan 07, at 5:26 PM 19 Jan 07, carlos@apache.org wrote:
>
> > Author: carlos
> > Date: Fri Jan 19 17:26:20 2007
> > New Revision: 498038
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=498038
> > Log:
> > Creating a embedder verifier
> >
> > Added:
> > maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> > maven/it/verifier/AbstractVerifier.java
> > - copied, changed from r498037, maven/shared/trunk/maven-
> > verifier/src/main/java/org/apache/maven/it/verifier/Verifier.java
> > Removed:
> > maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> > maven/it/verifier/Verifier.java
> >
> > Copied: maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> > maven/it/verifier/AbstractVerifier.java (from r498037, maven/shared/
> > trunk/maven-verifier/src/main/java/org/apache/maven/it/verifier/
> > Verifier.java)
> > URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-verifier/
> > src/main/java/org/apache/maven/it/verifier/AbstractVerifier.java?
> > view=diff&rev=498038&p1=maven/shared/trunk/maven-verifier/src/main/
> > java/org/apache/maven/it/verifier/Verifier.java&r1=498037&p2=maven/
> > shared/trunk/maven-verifier/src/main/java/org/apache/maven/it/
> > verifier/AbstractVerifier.java&r2=498038
> > ======================================================================
> > ========
> > --- maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> > maven/it/verifier/Verifier.java (original)
> > +++ maven/shared/trunk/maven-verifier/src/main/java/org/apache/
> > maven/it/verifier/AbstractVerifier.java Fri Jan 19 17:26:20 2007
> > @@ -1,21 +1,24 @@
> > package org.apache.maven.it.verifier;
> >
> > -import junit.framework.Assert;
> > -import org.apache.maven.it.util.FileUtils;
> > -import org.apache.maven.it.util.StringUtils;
> > -import org.apache.maven.it.util.cli.CommandLineException;
> > -import org.apache.maven.it.util.cli.CommandLineUtils;
> > -import org.apache.maven.it.util.cli.Commandline;
> > -import org.apache.maven.it.util.cli.StreamConsumer;
> > -import org.apache.maven.it.util.cli.WriterStreamConsumer;
> > -import org.xml.sax.InputSource;
> > -import org.xml.sax.SAXException;
> > -import org.xml.sax.SAXParseException;
> > -import org.xml.sax.helpers.DefaultHandler;
> > +/*
> > + * Licensed to the Apache Software Foundation (ASF) under one
> > + * or more contributor license agreements. See the NOTICE file
> > + * distributed with this work for additional information
> > + * regarding copyright ownership. The ASF licenses this file
> > + * to you under the Apache License, Version 2.0 (the
> > + * "License"); you may not use this file except in compliance
> > + * with the License. You may obtain a copy of the License at
> > + *
> > + * http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing,
> > + * software distributed under the License is distributed on an
> > + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > + * KIND, either express or implied. See the License for the
> > + * specific language governing permissions and limitations
> > + * under the License.
> > + */
> >
> > -import javax.xml.parsers.ParserConfigurationException;
> > -import javax.xml.parsers.SAXParser;
> > -import javax.xml.parsers.SAXParserFactory;
> > import java.io.BufferedReader;
> > import java.io.ByteArrayOutputStream;
> > import java.io.File;
> > @@ -41,13 +44,33 @@
> > import java.util.Properties;
> > import java.util.StringTokenizer;
> >
> > +import javax.xml.parsers.ParserConfigurationException;
> > +import javax.xml.parsers.SAXParser;
> > +import javax.xml.parsers.SAXParserFactory;
> > +
> > +import junit.framework.Assert;
> > +
> > +import org.apache.maven.it.VerificationException;
> > +import org.apache.maven.it.Verifier;
> > +import org.apache.maven.it.util.FileUtils;
> > +import org.apache.maven.it.util.StringUtils;
> > +import org.apache.maven.it.util.cli.CommandLineException;
> > +import org.apache.maven.it.util.cli.CommandLineUtils;
> > +import org.apache.maven.it.util.cli.Commandline;
> > +import org.apache.maven.it.util.cli.StreamConsumer;
> > +import org.apache.maven.it.util.cli.WriterStreamConsumer;
> > +import org.xml.sax.InputSource;
> > +import org.xml.sax.SAXException;
> > +import org.xml.sax.SAXParseException;
> > +import org.xml.sax.helpers.DefaultHandler;
> > +
> > /**
> > * @author <a href="mailto:jason@maven.org">Jason van Zyl </a>
> > * @author <a href="mailto:brett@apache.org">Brett Porter</a>
> > * @version $Id$
> > * @noinspection UseOfSystemOutOrSystemErr,RefusedBequest
> > */
> > -public class Verifier
> > +public abstract class AbstractVerifier
> > {
> > private static final String LOG_FILENAME = "log.txt";
> >
> > @@ -74,13 +97,13 @@
> >
> > private boolean debug;
> >
> > - public Verifier( String basedir, String settingsFile )
> > + public AbstractVerifier( String basedir, String settingsFile )
> > throws VerificationException
> > {
> > this( basedir, settingsFile, false );
> > }
> >
> > - public Verifier( String basedir, String settingsFile, boolean
> > debug )
> > + public AbstractVerifier( String basedir, String settingsFile,
> > boolean debug )
> > throws VerificationException
> > {
> > this.basedir = basedir;
> > @@ -101,13 +124,13 @@
> > findLocalRepo( settingsFile );
> > }
> >
> > - public Verifier( String basedir )
> > + public AbstractVerifier( String basedir )
> > throws VerificationException
> > {
> > this( basedir, null );
> > }
> >
> > - public Verifier( String basedir, boolean debug )
> > + public AbstractVerifier( String basedir, boolean debug )
> > throws VerificationException
> > {
> > this( basedir, null, debug );
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org