You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/26 12:14:14 UTC
[GitHub] [incubator-doris] icchux opened a new pull request, #9244: fix: Improved sequence function description doc-Zh
icchux opened a new pull request, #9244:
URL: https://github.com/apache/incubator-doris/pull/9244
use documents
# Proposed changes
Change function description document
Add table creation statement
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9244: [Fix][doc] Improved sequence function description doc-Zh
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9244:
URL: https://github.com/apache/incubator-doris/pull/9244#discussion_r870497783
##########
new-docs/zh-CN/data-operate/update-delete/sequence-column-manual.md:
##########
@@ -28,7 +29,7 @@ under the License.
sequence列目前只支持Uniq模型，Uniq模型主要针对需要唯一主键的场景，可以保证主键唯一性约束，但是由于使用REPLACE聚合方式，在同一批次中导入的数据，替换顺序不做保证，详细介绍可以参考[数据模型](../../data-table/data-model.md)。替换顺序无法保证则无法确定最终导入到表中的具体数据，存在了不确定性。
-为了解决这个问题，Doris支持了sequence列，通过用户在导入时指定sequence列，相同key列下，REPLACE聚合类型的列将按照sequence列的值进行替换，较大值可以替换较小值，反之则无法替换。该方法将顺序的确定交给了用户，由用户控制替换顺序。
+为了解决这个问题，Doris支持了sequence列，通过用户在导入时指定sequence列，对于该批次导入数据中相同key列的数据，REPLACE聚合类型的列将按照sequence列的值选取一个最大值所在的数据，从而替换Doris中对应key的数据。
Review Comment:
@icchux , we have just refactor the document. You need to modify the new doc here:
`docs//zh-CN/data-operate/update-delete/sequence-column-manual.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #9244: [Fix][doc] Improved sequence function description doc-Zh
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #9244:
URL: https://github.com/apache/incubator-doris/pull/9244#discussion_r861973901
##########
new-docs/zh-CN/data-operate/update-delete/sequence-column-manual.md:
##########
@@ -28,7 +29,7 @@ under the License.
sequence列目前只支持Uniq模型，Uniq模型主要针对需要唯一主键的场景，可以保证主键唯一性约束，但是由于使用REPLACE聚合方式，在同一批次中导入的数据，替换顺序不做保证，详细介绍可以参考[数据模型](../../data-table/data-model.md)。替换顺序无法保证则无法确定最终导入到表中的具体数据，存在了不确定性。
-为了解决这个问题，Doris支持了sequence列，通过用户在导入时指定sequence列，相同key列下，REPLACE聚合类型的列将按照sequence列的值进行替换，较大值可以替换较小值，反之则无法替换。该方法将顺序的确定交给了用户，由用户控制替换顺序。
+为了解决这个问题，Doris支持了sequence列，通过用户在导入时指定sequence列，对于该批次导入数据中相同key列的数据，REPLACE聚合类型的列将按照sequence列的值选取一个最大值所在的数据，从而替换Doris中对应key的数据。
Review Comment:
现在这句话还是很难理解。是不是这样写更好一些呢？
当key相同时，Doris会比较表中已存在数据和正在导入的数据。选取key相同的所有行中，sequence列的值最大的一行。并使用改行数据作为最终写入的数据。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org