You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/06/02 12:13:18 UTC

[jira] [Commented] (HADOOP-12051) ProtobufRpcEngine.invoke() should use Exception.toString() over getMessage in logging/span events

    [ https://issues.apache.org/jira/browse/HADOOP-12051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568890#comment-14568890 ] 

Hadoop QA commented on HADOOP-12051:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m 21s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 32s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 37s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  5s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 49s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  23m 26s | Tests passed in hadoop-common. |
| | |  62m 22s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12736795/HADOOP-12051.01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 990078b |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6892/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6892/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6892/console |


This message was automatically generated.

> ProtobufRpcEngine.invoke() should use Exception.toString() over getMessage in logging/span events
> -------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12051
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12051
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.7.0
>            Reporter: Steve Loughran
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: HADOOP-12051.01.patch
>
>
> in {{ProtobufRpcEngine.invoke()}}, caught throwables have their {{getMessage()} included in the timeline events for the span. For some events (eg NPE) this will be null. it should be calling {{toString()}} instead



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)