You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ce...@apache.org on 2023/03/14 16:11:22 UTC

[kafka] branch 3.4 updated: MINOR: Fix error check in Connect Worker zombie fencing (#13392)

This is an automated email from the ASF dual-hosted git repository.

cegerton pushed a commit to branch 3.4
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.4 by this push:
     new 1c5ba8b1d02 MINOR: Fix error check in Connect Worker zombie fencing (#13392)
1c5ba8b1d02 is described below

commit 1c5ba8b1d0230c56066569ac04d72987351d515c
Author: Yash Mayya <ya...@gmail.com>
AuthorDate: Tue Mar 14 21:39:52 2023 +0530

    MINOR: Fix error check in Connect Worker zombie fencing (#13392)
---
 .../runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
index f966ea4cb55..7186dbd5681 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
@@ -709,7 +709,7 @@ public class Worker {
                     FenceProducersOptions fencingOptions = new FenceProducersOptions()
                             .timeoutMs((int) ConnectResource.DEFAULT_REST_REQUEST_TIMEOUT_MS);
                     return admin.fenceProducers(transactionalIds, fencingOptions).all().whenComplete((ignored, error) -> {
-                        if (error != null)
+                        if (error == null)
                             log.debug("Finished fencing out {} task producers for source connector {}", numTasks, connName);
                         Utils.closeQuietly(admin, "Zombie fencing admin for connector " + connName);
                     });