You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by reddycharan <gi...@git.apache.org> on 2017/06/13 20:43:15 UTC
[GitHub] bookkeeper pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskf...
GitHub user reddycharan opened a pull request:
https://github.com/apache/bookkeeper/pull/190
BOOKKEEPER-1034: Bookie start in RO when diskfull
When the disk is above threshold, Bookie goes to RO. If we have to restart the
bookie, on the way back, bookie tries to create new entrylog and other files,
which will fail because disk usage is above threshold,
hence bookie refuses to come up. So with this fix we will try to start in RO
mode if RO is enabled.
Also, if bookie has died abruptly then it may missed flushing EntryMemtable and
IndexInMemoryPageManager. So next time when it starts when disc is full
it is failing to create index file and it is shutting down, though we expect it
to start in readonlymode. So Bookie should be able to create index file
though it has reached the diskusagethreshold, while starting the Bookie in
Readonly Mode. But ofcourse there should be some config to safeguard when
disk usable space is so low.
Minor fixes in shutdown logic of Bookie and Bookieserver.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reddycharan/bookkeeper bookiestartinreadonlywhendiskfull
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 4c3dccbb747c1403793c535760013007f633f2ca
Author: Charan Reddy Guttapalem <cg...@salesforce.com>
Date: 2017-03-30T01:30:22Z
BOOKKEEPER-1034: Bookie start in RO when diskfull
When the disk is above threshold, Bookie goes to RO. If we have to restart the
bookie, on the way back, bookie tries to create new entrylog and other files,
which will fail because disk usage is above threshold,
hence bookie refuses to come up. So with this fix we will try to start in RO
mode if RO is enabled.
Also, if bookie has died abruptly then it may missed flushing EntryMemtable and
IndexInMemoryPageManager. So next time when it starts when disc is full
it is failing to create index file and it is shutting down, though we expect it
to start in readonlymode. So Bookie should be able to create index file
though it has reached the diskusagethreshold, while starting the Bookie in
Readonly Mode. But ofcourse there should be some config to safeguard when
disk usable space is so low.
Minor fixes in shutdown logic of Bookie and Bookieserver.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #190: BOOKKEEPER-1034: Bookie start in RO when diskfull
Posted by reddycharan <gi...@git.apache.org>.
Github user reddycharan commented on the issue:
https://github.com/apache/bookkeeper/pull/190
@sijie fixed tailing spaces
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #190: BOOKKEEPER-1034: Bookie start in RO when diskfull
Posted by reddycharan <gi...@git.apache.org>.
Github user reddycharan commented on the issue:
https://github.com/apache/bookkeeper/pull/190
@sijie this is the fix we are having to deal with bookie start when ledgerdirs are full.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskf...
Posted by sijie <gi...@git.apache.org>.
Github user sijie closed the pull request at:
https://github.com/apache/bookkeeper/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #190: BOOKKEEPER-1034: Bookie start in RO when diskfull
Posted by reddycharan <gi...@git.apache.org>.
Github user reddycharan commented on the issue:
https://github.com/apache/bookkeeper/pull/190
@sijie if you dont have anymore comments, I can fix the tailing spaces and send new CR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #190: BOOKKEEPER-1034: Bookie start in RO when diskfull
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/190
@reddycharan I don't have more comments. please fix the tailing spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---