You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/11 03:28:37 UTC
Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Repository: mesos
Description
-------
Marked the agent as RESOURCE_PROVIDER capable.
Diffs
-----
src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60
Diff: https://reviews.apache.org/r/62880/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review187622
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62877, 62878, 62879, 62880]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 11, 2017, 11:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 11:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60
>
>
> Diff: https://reviews.apache.org/r/62880/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review187625
-----------------------------------------------------------
PASS: Mesos patch 62880 was successfully built and tested.
Reviews applied: `['62877', '62878', '62879', '62880']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62880
- Mesos Reviewbot Windows
On Oct. 11, 2017, 3:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 3:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60
>
>
> Diff: https://reviews.apache.org/r/62880/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Oct. 12, 2017, 5:39 p.m., Benjamin Bannier wrote:
> > I would much prefer if we'd add another patch before this that modifies the agent to e.g., fail over should it receive a `CheckpointResourcesMessage` and has this capability. Offer operation feedback and `CheckpointResourcesMessage` are incompatible, and we should prevent users from creating inconsistent cluster state.
https://reviews.apache.org/r/62974/
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review187781
-----------------------------------------------------------
On Oct. 11, 2017, 5:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60
>
>
> Diff: https://reviews.apache.org/r/62880/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review187781
-----------------------------------------------------------
I would much prefer if we'd add another patch before this that modifies the agent to e.g., fail over should it receive a `CheckpointResourcesMessage` and has this capability. Offer operation feedback and `CheckpointResourcesMessage` are incompatible, and we should prevent users from creating inconsistent cluster state.
src/tests/master_tests.cpp
Lines 4771-4772 (original), 4771-4772 (patched)
<https://reviews.apache.org/r/62880/#comment264827>
Update the comment as well.
src/tests/slave_tests.cpp
Lines 1565-1566 (original), 1565-1566 (patched)
<https://reviews.apache.org/r/62880/#comment264828>
Ditto.
- Benjamin Bannier
On Oct. 11, 2017, 5:28 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60
>
>
> Diff: https://reviews.apache.org/r/62880/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review188421
-----------------------------------------------------------
PASS: Mesos patch 62880 was successfully built and tested.
Reviews applied: `['63001', '62877', '62878', '62879', '62880']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62880
- Mesos Reviewbot Windows
On Oct. 17, 2017, 11:25 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 11:25 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6
>
>
> Diff: https://reviews.apache.org/r/62880/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review190299
-----------------------------------------------------------
I'd suggest to discard this patch in favor of the feature flag introduced in https://reviews.apache.org/r/63519/.
- Benjamin Bannier
On Oct. 18, 2017, 1:25 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 1:25 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6
>
>
> Diff: https://reviews.apache.org/r/62880/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/#review188426
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63001, 62877, 62878, 62879, 62880]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 17, 2017, 11:25 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62880/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 11:25 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8071
> https://issues.apache.org/jira/browse/MESOS-8071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked the agent as RESOURCE_PROVIDER capable.
>
>
> Diffs
> -----
>
> src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
> src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
> src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6
>
>
> Diff: https://reviews.apache.org/r/62880/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 11:25 p.m.)
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-8071
https://issues.apache.org/jira/browse/MESOS-8071
Repository: mesos
Description
-------
Marked the agent as RESOURCE_PROVIDER capable.
Diffs (updated)
-----
src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6
Diff: https://reviews.apache.org/r/62880/diff/3/
Changes: https://reviews.apache.org/r/62880/diff/2-3/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 7 p.m.)
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-8071
https://issues.apache.org/jira/browse/MESOS-8071
Repository: mesos
Description
-------
Marked the agent as RESOURCE_PROVIDER capable.
Diffs (updated)
-----
src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6
Diff: https://reviews.apache.org/r/62880/diff/2/
Changes: https://reviews.apache.org/r/62880/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER
capable.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62880/
-----------------------------------------------------------
(Updated Oct. 11, 2017, 3:28 a.m.)
Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
Bugs: MESOS-8071
https://issues.apache.org/jira/browse/MESOS-8071
Repository: mesos
Description
-------
Marked the agent as RESOURCE_PROVIDER capable.
Diffs
-----
src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab
src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df
src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60
Diff: https://reviews.apache.org/r/62880/diff/1/
Testing
-------
make check
Thanks,
Jie Yu