You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/04/08 19:40:29 UTC
[GitHub] [jena] afs opened a new pull request, #1836: GH-1835: Setup for SPARQL 1.2 grammar
afs opened a new pull request, #1836:
URL: https://github.com/apache/jena/pull/1836
GitHub issue resolved #1835
Pull request Description:
Makes no changes except to create the framework for SPARQL 1.2 and wire it in.
Initially, SPARQL 1.2 is the same as SPARQL 1.1, and does not include quoted triple; these are available in ARQ extended syntax and execution.
----
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1836: GH-1835: Setup for SPARQL 1.2 grammar
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #1836:
URL: https://github.com/apache/jena/pull/1836#discussion_r1161169712
##########
jena-arq/src/main/java/org/apache/jena/sparql/lang/ParserSPARQL12Update.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.sparql.lang;
+
+import java.io.Reader ;
+
+import org.apache.jena.atlas.logging.Log ;
+import org.apache.jena.query.QueryException ;
+import org.apache.jena.query.QueryParseException ;
+import org.apache.jena.shared.JenaException ;
+import org.apache.jena.sparql.core.Prologue;
+import org.apache.jena.sparql.lang.sparql_11.SPARQLParser11 ;
+import org.apache.jena.sparql.modify.UpdateSink ;
+import org.apache.jena.update.UpdateException ;
+
+public class ParserSPARQL12Update extends UpdateParser
+{
+ public ParserSPARQL12Update() {}
+
+ @Override
+ protected void executeParse(UpdateSink sink, Prologue prologue, Reader r) {
+ SPARQLParser11 parser = null ;
+ try {
+ parser = new SPARQLParser11(r);
Review Comment:
Shouldn't `ParserSPARQL12Update` be using `SPARQLParser12`?
##########
jena-arq/src/main/java/org/apache/jena/sparql/lang/ParserSPARQL12Update.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.sparql.lang;
+
+import java.io.Reader ;
+
+import org.apache.jena.atlas.logging.Log ;
+import org.apache.jena.query.QueryException ;
+import org.apache.jena.query.QueryParseException ;
+import org.apache.jena.shared.JenaException ;
+import org.apache.jena.sparql.core.Prologue;
+import org.apache.jena.sparql.lang.sparql_11.SPARQLParser11 ;
+import org.apache.jena.sparql.modify.UpdateSink ;
+import org.apache.jena.update.UpdateException ;
+
+public class ParserSPARQL12Update extends UpdateParser
+{
+ public ParserSPARQL12Update() {}
+
+ @Override
+ protected void executeParse(UpdateSink sink, Prologue prologue, Reader r) {
+ SPARQLParser11 parser = null ;
+ try {
+ parser = new SPARQLParser11(r);
Review Comment:
Or is it just for now until the SPARQL 1.2 is fully implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1836: GH-1835: Setup for SPARQL 1.2 grammar
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1836:
URL: https://github.com/apache/jena/pull/1836#discussion_r1161243145
##########
jena-arq/src/main/java/org/apache/jena/sparql/lang/ParserSPARQL12Update.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.sparql.lang;
+
+import java.io.Reader ;
+
+import org.apache.jena.atlas.logging.Log ;
+import org.apache.jena.query.QueryException ;
+import org.apache.jena.query.QueryParseException ;
+import org.apache.jena.shared.JenaException ;
+import org.apache.jena.sparql.core.Prologue;
+import org.apache.jena.sparql.lang.sparql_11.SPARQLParser11 ;
+import org.apache.jena.sparql.modify.UpdateSink ;
+import org.apache.jena.update.UpdateException ;
+
+public class ParserSPARQL12Update extends UpdateParser
+{
+ public ParserSPARQL12Update() {}
+
+ @Override
+ protected void executeParse(UpdateSink sink, Prologue prologue, Reader r) {
+ SPARQLParser11 parser = null ;
+ try {
+ parser = new SPARQLParser11(r);
Review Comment:
Thank you for catching that. I checked again, this time by deleting all the parsers! That reliably finds all uses in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1836: GH-1835: Setup for SPARQL 1.2 grammar
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #1836:
URL: https://github.com/apache/jena/pull/1836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org