You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2022/01/16 02:03:24 UTC

[commons-imaging] 24/24: [IMAGING-159] Remove ImageParser#isStrict, please use param.isStrict() now

This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git

commit 8825e26aff39d9d1d393503b80f15c02d8b6b60c
Author: Bruno P. Kinoshita <ki...@apache.org>
AuthorDate: Sun Jan 16 10:18:29 2022 +1300

    [IMAGING-159] Remove ImageParser#isStrict, please use param.isStrict() now
---
 src/main/java/org/apache/commons/imaging/ImageParser.java  | 14 --------------
 .../commons/imaging/formats/tiff/TiffImageParser.java      |  4 ++--
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/src/main/java/org/apache/commons/imaging/ImageParser.java b/src/main/java/org/apache/commons/imaging/ImageParser.java
index 0c25243..f2eea72 100644
--- a/src/main/java/org/apache/commons/imaging/ImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/ImageParser.java
@@ -941,18 +941,4 @@ public abstract class ImageParser<T extends ImagingParameters> extends BinaryFil
 
         return new SimpleBufferedImageFactory();
     }
-
-    /**
-     * A utility method to search a params specification and determine
-     * whether it contains the parameters contain the strict flag. Intended
-     * for internal use by ImageParser implementations.
-     *
-     * @param params optional parameters.
-     * @return If the params specify strict format compliance, true;
-     *         otherwise, false.
-     * @param <T> type of parameters used by this image parser
-     */
-    public static <T extends ImagingParameters> boolean isStrict(final T params) {
-        return params.isStrict();
-    }
 }
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
index a3bfef9..ac4fe02 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
@@ -322,7 +322,7 @@ public class TiffImageParser extends ImageParser<TiffImagingParameters> implemen
             params = new XmpImagingParameters();
         }
         final FormatCompliance formatCompliance = FormatCompliance.getDefault();
-        final TiffContents contents = new TiffReader(isStrict(params)).readDirectories(
+        final TiffContents contents = new TiffReader(params.isStrict()).readDirectories(
                 byteSource, false, formatCompliance);
         final TiffDirectory directory = contents.directories.get(0);
 
@@ -401,7 +401,7 @@ public class TiffImageParser extends ImageParser<TiffImagingParameters> implemen
             throws ImageReadException, IOException {
         final FormatCompliance formatCompliance = FormatCompliance.getDefault();
         final TiffImagingParameters params = new TiffImagingParameters();
-        new TiffReader(isStrict(params)).readContents(byteSource, params,
+        new TiffReader(params.isStrict()).readContents(byteSource, params,
                 formatCompliance);
         return formatCompliance;
     }