You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by SsnL <gi...@git.apache.org> on 2016/07/11 18:54:47 UTC

[GitHub] phoenix pull request #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload...

GitHub user SsnL opened a pull request:

    https://github.com/apache/phoenix/pull/178

    [PHOENIX-3061] IndexTool exits 0 even if bulkload failed with error

    **What**:
    Fix such that when the MapReduce job fails, the job exits with non-zero code and logs meaningful error message.
    
    **How**:
    Modified `IndexTool.configureSubmittableJobUsingDirectApi` and `IndexTool.configureRunnableJobUsingBulkLoad` so that they don't swallow errors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SsnL/phoenix PHOENIX_3061

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 8536ee221d8a706aa5f4ee3628be45b294216d4b
Author: Simon Wang <si...@airbnb.com>
Date:   2016-07-11T18:49:24Z

    [PHOENIX-3061] IndexTool marks index as ACTIVE and exit 0 even if bulkload has error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix issue #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload failed...

Posted by SsnL <gi...@git.apache.org>.

Github user SsnL commented on the issue:

    https://github.com/apache/phoenix/pull/178
  
    Reverted deleting reducer class.
    
    The tests still fail when `directAPI` and `transactional` are both set.
    
    @twdsilva any ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix issue #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload failed...

Posted by twdsilva <gi...@git.apache.org>.

Github user twdsilva commented on the issue:

    https://github.com/apache/phoenix/pull/178
  
    Looking into this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix issue #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload failed...

Posted by JamesRTaylor <gi...@git.apache.org>.

Github user JamesRTaylor commented on the issue:

    https://github.com/apache/phoenix/pull/178
  
    @gabrielreid or @SergeySoldatov - would you have a few spare cycles to review this small patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix issue #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload failed...

Posted by SsnL <gi...@git.apache.org>.

Github user SsnL commented on the issue:

    https://github.com/apache/phoenix/pull/178
  
    @twdsilva comes to save the day. 16/16 tests pass!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request #178: [PHOENIX-3061] IndexTool exits 0 even if bulkload...

Posted by SsnL <gi...@git.apache.org>.

Github user SsnL closed the pull request at:

    https://github.com/apache/phoenix/pull/178


---