You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/05/05 04:26:05 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #41054: [SPARK-43284][SQL][FOLLOWUP] Return URI encoded path, and add a test

cloud-fan commented on code in PR #41054:
URL: https://github.com/apache/spark/pull/41054#discussion_r1185686116


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala:
##########
@@ -267,7 +267,7 @@ object FileFormat {
   val BASE_METADATA_EXTRACTORS: Map[String, PartitionedFile => Any] = Map(
     FILE_PATH -> { pf: PartitionedFile =>
       // Use new Path(Path.toString).toString as a form of canonicalization

Review Comment:
   ```suggestion
         // Use `new Path(Path.toString)` as a form of canonicalization
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org