You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2017/10/10 01:42:10 UTC
Review Request 62855: HIVE-16677
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62855/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
Bugs: HIVE-16677
https://issues.apache.org/jira/browse/HIVE-16677
Repository: hive-git
Description
-------
HIVE-16677
Diffs
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 31e3ea159d7801c20e47fcc5a31de96988c0a812
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 35ea94f0dc230c30f64ac421930350d3ca5233c1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 56b437d1b228a92adee2644db65782cbe4bc518e
ql/src/test/queries/clientnegative/druid_datasource2.q PRE-CREATION
ql/src/test/results/clientnegative/druid_datasource2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/62855/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 62855: HIVE-16677
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62855/
-----------------------------------------------------------
(Updated Oct. 10, 2017, 9:09 p.m.)
Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
Bugs: HIVE-16677
https://issues.apache.org/jira/browse/HIVE-16677
Repository: hive-git
Description
-------
HIVE-16677
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 31e3ea159d7801c20e47fcc5a31de96988c0a812
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 35ea94f0dc230c30f64ac421930350d3ca5233c1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 56b437d1b228a92adee2644db65782cbe4bc518e
ql/src/test/queries/clientnegative/druid_datasource2.q PRE-CREATION
ql/src/test/results/clientnegative/druid_datasource2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/62855/diff/6/
Changes: https://reviews.apache.org/r/62855/diff/5-6/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 62855: HIVE-16677
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62855/
-----------------------------------------------------------
(Updated Oct. 10, 2017, 9:08 p.m.)
Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
Bugs: HIVE-16677
https://issues.apache.org/jira/browse/HIVE-16677
Repository: hive-git
Description
-------
HIVE-16677
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 31e3ea159d7801c20e47fcc5a31de96988c0a812
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 35ea94f0dc230c30f64ac421930350d3ca5233c1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 56b437d1b228a92adee2644db65782cbe4bc518e
ql/src/test/queries/clientnegative/druid_datasource2.q PRE-CREATION
ql/src/test/results/clientnegative/druid_datasource2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/62855/diff/5/
Changes: https://reviews.apache.org/r/62855/diff/4-5/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 62855: HIVE-16677
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62855/#review187588
-----------------------------------------------------------
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java
Lines 394 (patched)
<https://reviews.apache.org/r/62855/#comment264604>
We can just return if insert into has empty segments. Easier to read that way.
- Ashutosh Chauhan
On Oct. 10, 2017, 2:45 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62855/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2017, 2:45 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
>
>
> Bugs: HIVE-16677
> https://issues.apache.org/jira/browse/HIVE-16677
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16677
>
>
> Diffs
> -----
>
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 31e3ea159d7801c20e47fcc5a31de96988c0a812
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 35ea94f0dc230c30f64ac421930350d3ca5233c1
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 56b437d1b228a92adee2644db65782cbe4bc518e
> ql/src/test/queries/clientnegative/druid_datasource2.q PRE-CREATION
> ql/src/test/results/clientnegative/druid_datasource2.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62855/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 62855: HIVE-16677
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62855/
-----------------------------------------------------------
(Updated Oct. 10, 2017, 2:45 p.m.)
Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
Changes
-------
Reducing scope of try-catch to minimum.
Bugs: HIVE-16677
https://issues.apache.org/jira/browse/HIVE-16677
Repository: hive-git
Description
-------
HIVE-16677
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 31e3ea159d7801c20e47fcc5a31de96988c0a812
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 35ea94f0dc230c30f64ac421930350d3ca5233c1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 56b437d1b228a92adee2644db65782cbe4bc518e
ql/src/test/queries/clientnegative/druid_datasource2.q PRE-CREATION
ql/src/test/results/clientnegative/druid_datasource2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/62855/diff/4/
Changes: https://reviews.apache.org/r/62855/diff/3-4/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 62855: HIVE-16677
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62855/
-----------------------------------------------------------
(Updated Oct. 10, 2017, 2:30 p.m.)
Review request for hive, Ashutosh Chauhan and Slim Bouguerra.
Bugs: HIVE-16677
https://issues.apache.org/jira/browse/HIVE-16677
Repository: hive-git
Description
-------
HIVE-16677
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 31e3ea159d7801c20e47fcc5a31de96988c0a812
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 35ea94f0dc230c30f64ac421930350d3ca5233c1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 56b437d1b228a92adee2644db65782cbe4bc518e
ql/src/test/queries/clientnegative/druid_datasource2.q PRE-CREATION
ql/src/test/results/clientnegative/druid_datasource2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/62855/diff/2/
Changes: https://reviews.apache.org/r/62855/diff/1-2/
Testing
-------
Thanks,
Jesús Camacho Rodríguez