You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 16:18:06 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #25980: Remove Amazon S3 Connection Type

Taragolis commented on code in PR #25980:
URL: https://github.com/apache/airflow/pull/25980#discussion_r969835611


##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -127,9 +127,18 @@ def __post_init__(self, conn: "Connection"):
         self.password = conn.password
         self.extra_config = deepcopy(conn.extra_dejson)
 
-        if self.conn_type != "aws":
+        if self.conn_type.lower() == "s3":

Review Comment:
   If conn_type is None or empty than replaced to `aws`
   
   https://github.com/apache/airflow/blob/bdb4492525f4cb1bd129d5977f8f3fb4c0c6b850/airflow/providers/amazon/aws/utils/connection_wrapper.py#L125-L126



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org