[GitHub] sandeep-krishnamurthy commented on a change in pull request #10429: [MXNET-210]give warning for variables with same name in graph visualization

[GitBox <gi...@apache.org>]

sandeep-krishnamurthy commented on a change in pull request #10429: [MXNET-210]give warning for variables with same name in graph visualization
URL: https://github.com/apache/incubator-mxnet/pull/10429#discussion_r180199629
 
 

 ##########
 File path: python/mxnet/visualization.py
 ##########
 @@ -252,6 +252,10 @@ def plot_network(symbol, title="plot", save_format='pdf', shape=None, node_attrs
         shape_dict = dict(zip(interals.list_outputs(), out_shapes))
     conf = json.loads(symbol.tojson())
     nodes = conf["nodes"]
+    # check if multiple nodes have the same name
+    if len(nodes) != len(set([node["name"] for node in nodes])):
+        logging.warning("There are multiple variables with the same name in your graph, "
 
 Review comment:
   It would good to print the duplicate name in your warning message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services