You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/11/18 14:28:02 UTC
[GitHub] [fineract] avikganguly01 opened a new pull request #1501: README update for WAR file
avikganguly01 opened a new pull request #1501:
URL: https://github.com/apache/fineract/pull/1501
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on a change in pull request #1501: README update for WAR file
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on a change in pull request #1501:
URL: https://github.com/apache/fineract/pull/1501#discussion_r526133622
##########
File path: README.md
##########
@@ -59,7 +59,7 @@ The tenants database connection details are configured [via environment variable
Instructions to build a WAR file
============
1. Clone the repository or download and extract the archive file to your local directory.
-2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `build/libs` directory.
+2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `fineract-provider/build/libs` directory.
3. Deploy this WAR to your Tomcat v9 Servlet Container.
We recommend using the JAR instead of the WAR file deployment, because it's much easier.
Review comment:
@vorburger @vidakovic
Is this line necessary?
Is it easier to configure SSL certificate for JAR file instead of Tomcat WAR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1501: README update for WAR file
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1501:
URL: https://github.com/apache/fineract/pull/1501#discussion_r526477028
##########
File path: README.md
##########
@@ -59,7 +59,7 @@ The tenants database connection details are configured [via environment variable
Instructions to build a WAR file
============
1. Clone the repository or download and extract the archive file to your local directory.
-2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `build/libs` directory.
+2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `fineract-provider/build/libs` directory.
3. Deploy this WAR to your Tomcat v9 Servlet Container.
We recommend using the JAR instead of the WAR file deployment, because it's much easier.
Review comment:
I don't recommend that you configure the SSL certificate at all... :smile: E.g. on https://www.fineract.dev I actually do not do that! You ask how it works :smiling_imp: then? It's now documented on https://github.com/apache/fineract/pull/1503, waiting for your review... :smile: This PR LGTM as is, to me; I wouldn't change this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1501: README update for WAR file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1501:
URL: https://github.com/apache/fineract/pull/1501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1501: README update for WAR file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1501:
URL: https://github.com/apache/fineract/pull/1501#issuecomment-748389903
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org