You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/19 22:03:18 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10270: [Issue-10269] [pulsar-io] Pulsar IO Sink errors are not bubbled up correctly

jerrypeng commented on a change in pull request #10270:
URL: https://github.com/apache/pulsar/pull/10270#discussion_r616207484



##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -322,6 +322,7 @@ private void processResult(Record srcRecord,
                         srcRecord, t);
                 stats.incrUserExceptions(t);
                 srcRecord.fail();
+                throw new RuntimeException(t);

Review comment:
       The error here is an exception that happened in the user function not sink.  Also because it is in the result.whenComplete clause, anything thrown in there will not be bubbled to the main thread




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org