You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ka-weihe (via GitHub)" <gi...@apache.org> on 2024/06/18 11:04:44 UTC

[PR] fix: filters not updating with force update when caching is enabled [superset]

ka-weihe opened a new pull request, #29291:
URL: https://github.com/apache/superset/pull/29291

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Currently, when you have caching enabled and you click "refresh dashboard" it only updates the charts but not the filters. This is despite the filters having a loading spinner next to them.
   
   ### TESTING INSTRUCTIONS
   1. Setup Superset with caching
   2. Create a dataset with a simple table with a create any charts and add it to a dashboard. Add a filter to the dashboard - could the values of one of the columns. Insert a new row to the table with a new value for the column you have created a filter for.
   3. Force refresh the dashboard using "refresh dashboard" in the upper right hand corner. 
   
   You will see your chart updating, but not the filter. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   https://github.com/apache/superset/issues/25893
   https://github.com/apache/superset/issues/21234
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: filters not updating with force update when caching is enabled [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #29291:
URL: https://github.com/apache/superset/pull/29291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org