[GitHub] [spark] sarutak commented on a change in pull request #33937: [SPARK-35822][UI] Spark UI-Executor tab is empty in IE11

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #33937:
URL: https://github.com/apache/spark/pull/33937#discussion_r704885614



##########
File path: core/src/main/resources/org/apache/spark/ui/static/utils.js
##########
@@ -227,4 +227,12 @@ function createRESTEndPointForMiscellaneousProcess(appId) {
   }
   return uiRoot + "/api/v1/applications/" + appId + "/allmiscellaneousprocess";
 }
+
+function getBaseURI(){
+  let baseURI = document.baseURI;
+  if(!baseURI){

Review comment:
       ```suggestion
     if (!baseURI){
   ```
   
   Or, simply can we simply do `document.baseURI || document.URL`?

##########
File path: core/src/main/resources/org/apache/spark/ui/static/utils.js
##########
@@ -227,4 +227,12 @@ function createRESTEndPointForMiscellaneousProcess(appId) {
   }
   return uiRoot + "/api/v1/applications/" + appId + "/allmiscellaneousprocess";
 }
+
+function getBaseURI(){
+  let baseURI = document.baseURI;

Review comment:
       This change seems to aim IE11. Is it support EC6 features? (`let` here).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org