You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/10 21:34:24 UTC
[GitHub] [tvm] mherkazandjian opened a new pull request #8239: use the latest tag instead of the master branch of papi in the ci
mherkazandjian opened a new pull request #8239:
URL: https://github.com/apache/tvm/pull/8239
The CI docker build tvm.ci_cpu fails with the current master of papi
https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_papi.sh#L29
the offending papi commit is
https://bitbucket.org/icl/papi/commits/1f48bb789bb8a42e7f1e3faec4e49487af14bf46
apparently the papi CI is broken too
i tried to build the docker ci_cpu while going back in the commits on the master branch of papi
and i think the safest to use is the use the latest papi stable tag.
with this patch the tvm ci_cpu docker container builds successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mherkazandjian closed pull request #8239: use the latest tag instead of the master branch of papi in the ci
Posted by GitBox <gi...@apache.org>.
mherkazandjian closed pull request #8239:
URL: https://github.com/apache/tvm/pull/8239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #8239: use the latest tag instead of the master branch of papi in the ci
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #8239:
URL: https://github.com/apache/tvm/pull/8239#discussion_r649558973
##########
File path: docker/install/ubuntu_install_papi.sh
##########
@@ -26,7 +26,7 @@ apt-get update --fix-missing
apt-get install -y linux-tools-common linux-tools-generic
cd /
-git clone https://bitbucket.org/icl/papi.git
+git clone -b stable-6.0 --single-branch https://bitbucket.org/icl/papi.git
Review comment:
This will not work as we need to include this commit (https://bitbucket.org/icl/papi/commits/a0d7cf0d5929f2115636e77317daa0f00d075e08) in order for papi to work with CUDA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mherkazandjian commented on a change in pull request #8239: use the latest tag instead of the master branch of papi in the ci
Posted by GitBox <gi...@apache.org>.
mherkazandjian commented on a change in pull request #8239:
URL: https://github.com/apache/tvm/pull/8239#discussion_r649584353
##########
File path: docker/install/ubuntu_install_papi.sh
##########
@@ -26,7 +26,7 @@ apt-get update --fix-missing
apt-get install -y linux-tools-common linux-tools-generic
cd /
-git clone https://bitbucket.org/icl/papi.git
+git clone -b stable-6.0 --single-branch https://bitbucket.org/icl/papi.git
Review comment:
i see. well, this is quite inconvenient at the moment. I think this error can be fixed by solving the papi compile issue
in the papi repo, that is another solution, but i am not sure how long that will take them to fix.
we could alternatively checkout the commit you refernced above instead of the stable tag (as a temporary fix)?
that would get the docker ci_cpu image build to succeed at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mherkazandjian commented on a change in pull request #8239: use the latest tag instead of the master branch of papi in the ci
Posted by GitBox <gi...@apache.org>.
mherkazandjian commented on a change in pull request #8239:
URL: https://github.com/apache/tvm/pull/8239#discussion_r649611628
##########
File path: docker/install/ubuntu_install_papi.sh
##########
@@ -26,7 +26,7 @@ apt-get update --fix-missing
apt-get install -y linux-tools-common linux-tools-generic
cd /
-git clone https://bitbucket.org/icl/papi.git
+git clone -b stable-6.0 --single-branch https://bitbucket.org/icl/papi.git
Review comment:
i pointed the checkout to the latest commit in papi where the build succeeds
https://github.com/mherkazandjian/tvm/commit/eb6e7d235ebd1f41bcf44ee7c7b306a5911930c8
##########
File path: docker/install/ubuntu_install_papi.sh
##########
@@ -26,7 +26,7 @@ apt-get update --fix-missing
apt-get install -y linux-tools-common linux-tools-generic
cd /
-git clone https://bitbucket.org/icl/papi.git
+git clone -b stable-6.0 --single-branch https://bitbucket.org/icl/papi.git
Review comment:
papi just reverted the offending commit
https://bitbucket.org/icl/papi/issues/84/build-of-the-master-branch-is-failing-with
we can close close this PR and the issue https://github.com/apache/tvm/issues/8173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #8239: use the latest tag instead of the master branch of papi in the ci
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #8239:
URL: https://github.com/apache/tvm/pull/8239#issuecomment-859104073
Our current approach is to not fix versions of dependencies in the docker images. The problem is that we hit things like this. I'm not sure what we want to do as a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org