[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2237: IGNITE-19777 Perform local metastorage recovery

["SammyVimes (via GitHub)" <gi...@apache.org>]

SammyVimes commented on code in PR #2237:
URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1241942617


##########
modules/runner/src/main/java/org/apache/ignite/internal/recovery/ConfigurationCatchUpListener.java:
##########
@@ -84,6 +84,7 @@ private boolean isConfigurationUpToDate(long targetRevision, long appliedRevisio
     private CompletableFuture<?> checkRevisionUpToDate(long appliedRevision) {
         return cfgStorage.lastRevision().thenAccept(rev -> {
             synchronized (targetRevisionUpdateMutex) {
+                // TODO: actual metastorage  revision can be higher than configuration revision

Review Comment:
   Whoops, that was a message to myself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org