You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/31 08:39:19 UTC
[GitHub] [flink] zentol opened a new pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
zentol opened a new pull request #18565:
URL: https://github.com/apache/flink/pull/18565
- drop zookeeper 3.4
- zookeeper 3.5 is new default
- zookeeper 3.6 is new opt-in version
- exclude all optional netty dependencies of zookeeper as we don't need them
- HBase pinned to 3.4 because of HBase limitations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18565:
URL: https://github.com/apache/flink/pull/18565#issuecomment-1025498628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4a53bc843f607a866c795cd983d71e811e513ef2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30497",
"triggerID" : "4a53bc843f607a866c795cd983d71e811e513ef2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a53bc843f607a866c795cd983d71e811e513ef2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30497)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18565:
URL: https://github.com/apache/flink/pull/18565#issuecomment-1025498628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4a53bc843f607a866c795cd983d71e811e513ef2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30497",
"triggerID" : "4a53bc843f607a866c795cd983d71e811e513ef2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a53bc843f607a866c795cd983d71e811e513ef2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30497)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18565:
URL: https://github.com/apache/flink/pull/18565#discussion_r795605984
##########
File path: pom.xml
##########
@@ -723,10 +723,10 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
- <!-- Netty is only needed for ZK servers, not clients -->
<exclusion>
+ <!-- Netty is an optional dependency, that we currently do not make use of. -->
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>*</artifactId>
Review comment:
Because it is outdated and only applies to netty 3, while the current ZK versions rely on netty 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18565:
URL: https://github.com/apache/flink/pull/18565#issuecomment-1025500042
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4a53bc843f607a866c795cd983d71e811e513ef2 (Mon Jan 31 08:44:16 UTC 2022)
**Warnings:**
* **6 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #18565:
URL: https://github.com/apache/flink/pull/18565#discussion_r795538573
##########
File path: flink-end-to-end-tests/test-scripts/test_ha_datastream.sh
##########
@@ -98,6 +98,6 @@ function run_ha_test() {
STATE_BACKEND_TYPE=${1:-file}
STATE_BACKEND_FILE_ASYNC=${2:-true}
STATE_BACKEND_ROCKS_INCREMENTAL=${3:-false}
-ZOOKEEPER_VERSION=${4:-3.4}
+ZOOKEEPER_VERSION=${4:-3.5}
Review comment:
Shall we move that into a variable `DEFAULT_ZOOKEEPER_VERSION` in `common_ha.sh`?
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -246,7 +246,7 @@ public FlinkContainers build() {
private GenericContainer<?> buildZookeeperContainer() {
return configureContainer(
- new GenericContainer<>(DockerImageName.parse("zookeeper").withTag("3.4.14")),
+ new GenericContainer<>(DockerImageName.parse("zookeeper").withTag("3.5.9")),
Review comment:
What about loading the value from the pom file instead of having it duplicated here? 🤔
##########
File path: pom.xml
##########
@@ -120,9 +120,9 @@ under the License.
<scala.version>2.12.7</scala.version>
<scala.binary.version>2.12</scala.binary.version>
<chill.version>0.7.6</chill.version>
- <zookeeper.version>3.4.14</zookeeper.version>
- <!-- Only the curator2 TestingServer works with ZK 3.4 -->
- <curator.version>2.12.0</curator.version>
+ <!-- keep FlinkContainersBuilder#buildZookeeperContainer() in sync -->
Review comment:
fair enough ¯\_(ツ)_/¯
##########
File path: pom.xml
##########
@@ -723,10 +723,10 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
- <!-- Netty is only needed for ZK servers, not clients -->
<exclusion>
+ <!-- Netty is an optional dependency, that we currently do not make use of. -->
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>*</artifactId>
Review comment:
What's the motivation behind extending the scope of this exclusion? And should we add this as a separate commit?
##########
File path: flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh
##########
@@ -153,6 +153,6 @@ function run_ha_test() {
STATE_BACKEND_TYPE=${1:-file}
STATE_BACKEND_FILE_ASYNC=${2:-true}
STATE_BACKEND_ROCKS_INCREMENTAL=${3:-false}
-ZOOKEEPER_VERSION=${4:-3.4}
+ZOOKEEPER_VERSION=${4:-3.5}
Review comment:
Like in the previous comment: Shall we move this into a variable since it's used in two places? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18565:
URL: https://github.com/apache/flink/pull/18565#discussion_r795599352
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -246,7 +246,7 @@ public FlinkContainers build() {
private GenericContainer<?> buildZookeeperContainer() {
return configureContainer(
- new GenericContainer<>(DockerImageName.parse("zookeeper").withTag("3.4.14")),
+ new GenericContainer<>(DockerImageName.parse("zookeeper").withTag("3.5.9")),
Review comment:
I created a ticket for that: https://issues.apache.org/jira/browse/FLINK-25886
We'll have to see how easy it is to set this up while still making things work out-of-the-box in IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18565:
URL: https://github.com/apache/flink/pull/18565#discussion_r795613187
##########
File path: flink-end-to-end-tests/test-scripts/test_ha_datastream.sh
##########
@@ -98,6 +98,6 @@ function run_ha_test() {
STATE_BACKEND_TYPE=${1:-file}
STATE_BACKEND_FILE_ASYNC=${2:-true}
STATE_BACKEND_ROCKS_INCREMENTAL=${3:-false}
-ZOOKEEPER_VERSION=${4:-3.4}
+ZOOKEEPER_VERSION=${4:-3.5}
Review comment:
as far as I'm concerned these shouldn't have defaults in the first place; but changing these here is less work than doing the error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #18565:
URL: https://github.com/apache/flink/pull/18565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18565:
URL: https://github.com/apache/flink/pull/18565#issuecomment-1025498628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4a53bc843f607a866c795cd983d71e811e513ef2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a53bc843f607a866c795cd983d71e811e513ef2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a53bc843f607a866c795cd983d71e811e513ef2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18565: [FLINK-25145][build] Drop ZK 3.4 / Support ZK 3.6
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18565:
URL: https://github.com/apache/flink/pull/18565#discussion_r795605984
##########
File path: pom.xml
##########
@@ -723,10 +723,10 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
- <!-- Netty is only needed for ZK servers, not clients -->
<exclusion>
+ <!-- Netty is an optional dependency, that we currently do not make use of. -->
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>*</artifactId>
Review comment:
Because only applies to netty 3 which ZK 3.4 was using, while the current ZK versions rely on netty 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org