You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:33:08 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
dongjoon-hyun opened a new pull request #29298:
URL: https://github.com/apache/spark/pull/29298
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666413095
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29298:
URL: https://github.com/apache/spark/pull/29298#discussion_r462780182
##########
File path: core/src/test/resources/HistoryServerExpectations/app_environment_expectation.json
##########
@@ -5,283 +5,283 @@
"scalaVersion" : "version 2.11.8"
},
"sparkProperties" : [
Review comment:
The change of this file is a simple sorting.
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
This is intentionally copied from `2.12` test case. If we change `2.13` here, we need to change `2.12`, too.
- https://github.com/apache/spark/pull/29298/files#diff-2ebc20516434bc6dc6ad4e9698e9b15bR239-R261
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
I'd like to avoid touching the existing Scala 2.12 test case~
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Oh, something looks incorrect. Let me check again.
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Got it. My bad.
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Thanks! It's fixed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666485513
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29298:
URL: https://github.com/apache/spark/pull/29298#discussion_r462787946
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Maybe `"${Utils.DEFAULT_DRIVER_MEM_MB}m"`?
##########
File path: core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Eh, https://github.com/apache/spark/pull/29298/files#diff-2ebc20516434bc6dc6ad4e9698e9b15bR239-R261 has `"${Utils.DEFAULT_DRIVER_MEM_MB}m"` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666413470
Thanks, @srowen . Yes. It does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29298:
URL: https://github.com/apache/spark/pull/29298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666170687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666495942
Rebased to the master to bring @HyukjinKwon 's GitHub Action fixes. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666495942
Rebased to the master to bring @HyukjinKwon 's GitHub Action fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666413470
Thanks, @srowen .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666565853
All test passed except the `ExecutorSuite` which is known to be flaky in these day. I'll merge this. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29298: [SPARK-32489][CORE] Pass `core` module UTs in Scala 2.13
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29298:
URL: https://github.com/apache/spark/pull/29298#issuecomment-666169269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org