[Java] fanout exchange, JMX bindings() results

[Robbie Gemmell <ro...@gmail.com>]

Hi all,

The Exchange MBeans have a bindings() method that returns the
information in a TabularData object containing CompositeData results.
The direct, fanout, and topic exchanges generate a result set where
each element contains: String BindingKey and String[ ] Queues (the
headers exchange does something different <mutter mutter>, but I
digress...).

The direct exchange does the obvious and returns a series of
CompositeData elements containing the queue name and an array also
containing the queue name. The not so obvious thing to me is that the
fanout exchange does the same. This produces a results view like shown
below, whereby there is a 'binding key' for every queue bound to the
exchange (when infact no binding key at all is used for the exchange),
each associated with the single queue.

http://people.apache.org/~robbie/qpid/gsoc/screenshots_22july2009/fanout_exchange1.png

I dont really like that, it isnt representative of whats actually
going on, so id like to change it to return a single CompositeData
element within the TabularData which contains a 'wildcard binding'
with all the queue names in the associated list. This would lead to a
results view which looked like below:

http://people.apache.org/~robbie/qpid/gsoc/screenshots_22july2009/fanout_exchange2.png

I think thats more in keeping with whats actually going on and more
descriptive of how the exchange actually works.

Are there any objections to this change? If not ill commit it tomorrow.


Robbie

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: [Java] fanout exchange, JMX bindings() results

[Aidan Skinner <ai...@gmail.com>]

On Wed, Jul 22, 2009 at 10:19 AM, Robbie
Gemmell<ro...@gmail.com> wrote:

> I dont really like that, it isnt representative of whats actually
> going on, so id like to change it to return a single CompositeData
> element within the TabularData which contains a 'wildcard binding'
> with all the queue names in the associated list. This would lead to a
> results view which looked like below:
>
> http://people.apache.org/~robbie/qpid/gsoc/screenshots_22july2009/fanout_exchange2.png
>
> I think thats more in keeping with whats actually going on and more
> descriptive of how the exchange actually works.

That looks like a good plan to me. :)

- Aidan

-- 
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org