You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/11 20:35:11 UTC
[GitHub] codecov-io edited a comment on issue #3682: Change javadoc in
RealtimeSegmentRelocator
codecov-io edited a comment on issue #3682: Change javadoc in RealtimeSegmentRelocator
URL: https://github.com/apache/incubator-pinot/pull/3682#issuecomment-453641030
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=h1) Report
> Merging [#3682](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/e7b20da3a3ef6f6a29f4c3f359aafdf96da1e134?src=pr&el=desc) will **increase** coverage by `21.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3682 +/- ##
=============================================
+ Coverage 45.9% 67.23% +21.33%
- Complexity 0 4 +4
=============================================
Files 1027 1027
Lines 50863 50863
Branches 7106 7106
=============================================
+ Hits 23349 34200 +10851
+ Misses 25556 14340 -11216
- Partials 1958 2323 +365
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `78.57% <ø> (+60.2%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [.../BrokerResourceOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclJlc291cmNlT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `49.15% <0%> (-10.17%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `68.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `86.66% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `89.03% <0%> (+0.32%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ava/org/apache/pinot/common/request/Selection.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9TZWxlY3Rpb24uamF2YQ==) | `35.8% <0%> (+0.49%)` | `0% <0%> (ø)` | :arrow_down: |
| [...i/resources/PinotSegmentUploadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZFJlc3RsZXRSZXNvdXJjZS5qYXZh) | `65.32% <0%> (+0.5%)` | `0% <0%> (ø)` | :arrow_down: |
| [...re/realtime/impl/kafka/KafkaConnectionHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2thZmthL0thZmthQ29ubmVjdGlvbkhhbmRsZXIuamF2YQ==) | `69.69% <0%> (+0.6%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `93.9% <0%> (+0.6%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [516 more](https://codecov.io/gh/apache/incubator-pinot/pull/3682/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=footer). Last update [e7b20da...1ff65bc](https://codecov.io/gh/apache/incubator-pinot/pull/3682?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org