You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/30 12:24:18 UTC

[GitHub] [spark] beliefer opened a new pull request, #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable message name.

beliefer opened a new pull request, #38061:
URL: https://github.com/apache/spark/pull/38061

   ### What changes were proposed in this pull request?
   We are very concerned about the progress of the Spark Connect, so we understand the current draft and read preliminary implementation. We can see that the message names of some protocol buffers are inappropriate, or even cause confusion. Therefore, this PR try to correct it.
   
   
   ### Why are the changes needed?
   Use more suitable message name.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Spark Connect just started.
   
   
   ### How was this patch tested?
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1272780961

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style.

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1272495503

   cc @dongjoon-hyun @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable message name.

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1272192076

   > Before that is achieved, the idea could be that we limit changes on the proto to only core API coverage to unblock other pieces (DataFrame API support in clients etc.)
   
   Thank you. I will revert the changes on the proto. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] amaliujia commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable message name.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1263798502

   It's ok to fix code style on, for example, scala server side. 
   
   I want to hold a bit on the proto side. The proto itself will evolve quickly and itself is not at a stable position now. Whatever we change now could be no longer useful soon. Plus every time we update the proto we need to update the generate file on the python side. We are planing to change the python side with some sort of automatic way for python proto generation. 
   
   Before that is achieved, the idea could be that we limit changes on the proto to only core API coverage to unblock other pieces (DataFrame API etc.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style.

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1272856905

   @amaliujia @grundprinzip @HyukjinKwon Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style.

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38061:
URL: https://github.com/apache/spark/pull/38061#issuecomment-1272226935

   ping @grundprinzip 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38061: [SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style.
URL: https://github.com/apache/spark/pull/38061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org