You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "Bruno Mahé (Created JIRA)" <ji...@apache.org> on 2012/04/12 01:29:16 UTC

[jira] [Created] (BIGTOP-524) Add tests to verify that our init scripts conform to the LSB specification

Add tests to verify that our init scripts conform to the LSB specification
--------------------------------------------------------------------------

                 Key: BIGTOP-524
                 URL: https://issues.apache.org/jira/browse/BIGTOP-524
             Project: Bigtop
          Issue Type: New Feature
          Components: Tests
    Affects Versions: 0.3.0, 0.4.0
            Reporter: Bruno Mahé


I recently submitted BIGTOP-505 and BIGTOP-506, but we should proactively verify all our init scripts follow the LSB specification.
This would avoid some issues where for instance third party tools get confused by the return code of some action.

So we should add tests to ensure that init scripts follow http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Here are some cased to be checked (extract from the spec linked above):
{noformat}
For all other init-script actions, the init script shall return an exit status of zero if the action was successful. Otherwise, the exit status shall be non-zero, as defined below. In addition to straightforward success, the following situations are also to be considered successful:

    restarting a service (instead of reloading it) with the force-reload argument

    running start on a service already running

    running stop on a service already stopped or not running

    running restart on a service already stopped or not running

    running try-restart on a service already stopped or not running
{noformat}



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BIGTOP-524) Add tests to verify that our init scripts conform to the LSB specification

Posted by "Roman Shaposhnik (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252055#comment-13252055 ] 

Roman Shaposhnik commented on BIGTOP-524:
-----------------------------------------

We do quite a bit of that here (more tests are welcome):
   https://github.com/apache/bigtop/blob/trunk/bigtop-tests/test-artifacts/package/src/main/groovy/org/apache/bigtop/itest/packagesmoke/PackageTestCommon.groovy#L133

The trouble is that our automated package testing has fallen through the cracks. :-(

We really should make it a priority for Bigtop 0.4.0 to at least *run* this stuff.
                
> Add tests to verify that our init scripts conform to the LSB specification
> --------------------------------------------------------------------------
>
>                 Key: BIGTOP-524
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-524
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: Tests
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Bruno Mahé
>
> I recently submitted BIGTOP-505 and BIGTOP-506, but we should proactively verify all our init scripts follow the LSB specification.
> This would avoid some issues where for instance third party tools get confused by the return code of some action.
> So we should add tests to ensure that init scripts follow http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> Here are some cased to be checked (extract from the spec linked above):
> {noformat}
> For all other init-script actions, the init script shall return an exit status of zero if the action was successful. Otherwise, the exit status shall be non-zero, as defined below. In addition to straightforward success, the following situations are also to be considered successful:
>     restarting a service (instead of reloading it) with the force-reload argument
>     running start on a service already running
>     running stop on a service already stopped or not running
>     running restart on a service already stopped or not running
>     running try-restart on a service already stopped or not running
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BIGTOP-524) Add tests to verify that our init scripts conform to the LSB specification

Posted by "Bruno Mahé (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252242#comment-13252242 ] 

Bruno Mahé commented on BIGTOP-524:
-----------------------------------

Agreed. We should always run them.
But still, the test cases you are pointing too is missing quite a few cases
                
> Add tests to verify that our init scripts conform to the LSB specification
> --------------------------------------------------------------------------
>
>                 Key: BIGTOP-524
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-524
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: Tests
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Bruno Mahé
>
> I recently submitted BIGTOP-505 and BIGTOP-506, but we should proactively verify all our init scripts follow the LSB specification.
> This would avoid some issues where for instance third party tools get confused by the return code of some action.
> So we should add tests to ensure that init scripts follow http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> Here are some cased to be checked (extract from the spec linked above):
> {noformat}
> For all other init-script actions, the init script shall return an exit status of zero if the action was successful. Otherwise, the exit status shall be non-zero, as defined below. In addition to straightforward success, the following situations are also to be considered successful:
>     restarting a service (instead of reloading it) with the force-reload argument
>     running start on a service already running
>     running stop on a service already stopped or not running
>     running restart on a service already stopped or not running
>     running try-restart on a service already stopped or not running
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (BIGTOP-524) Add tests to verify that our init scripts conform to the LSB specification

Posted by "Bruno Mahé (Issue Comment Edited JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252242#comment-13252242 ] 

Bruno Mahé edited comment on BIGTOP-524 at 4/12/12 6:38 AM:
------------------------------------------------------------

Agreed. We should always run them.
But still, the test cases you are pointing too are missing quite a few cases
                
      was (Author: bmahe):
    Agreed. We should always run them.
But still, the test cases you are pointing too is missing quite a few cases
                  
> Add tests to verify that our init scripts conform to the LSB specification
> --------------------------------------------------------------------------
>
>                 Key: BIGTOP-524
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-524
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: Tests
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Bruno Mahé
>
> I recently submitted BIGTOP-505 and BIGTOP-506, but we should proactively verify all our init scripts follow the LSB specification.
> This would avoid some issues where for instance third party tools get confused by the return code of some action.
> So we should add tests to ensure that init scripts follow http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> Here are some cased to be checked (extract from the spec linked above):
> {noformat}
> For all other init-script actions, the init script shall return an exit status of zero if the action was successful. Otherwise, the exit status shall be non-zero, as defined below. In addition to straightforward success, the following situations are also to be considered successful:
>     restarting a service (instead of reloading it) with the force-reload argument
>     running start on a service already running
>     running stop on a service already stopped or not running
>     running restart on a service already stopped or not running
>     running try-restart on a service already stopped or not running
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira