You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/11/08 19:09:48 UTC
[kudu-CR] [java client] Wrong javadoc in KuduClient
Hello Adar Dembo, John Russell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5001
to review the following change.
Change subject: [java client] Wrong javadoc in KuduClient
......................................................................
[java client] Wrong javadoc in KuduClient
Timeouts on join were removed in the sync API but KuduClient's javadoc wasn't adjusted.
Change-Id: Iddf2e33b82002535eb1f8baefaccccdc1405a9c2
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5001/1
--
To view, visit http://gerrit.cloudera.org:8080/5001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddf2e33b82002535eb1f8baefaccccdc1405a9c2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[kudu-CR] [java client] Wrong javadoc in KuduClient
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [java client] Wrong javadoc in KuduClient
......................................................................
[java client] Wrong javadoc in KuduClient
Timeouts on join were removed in the sync API but KuduClient's javadoc wasn't adjusted.
Change-Id: Iddf2e33b82002535eb1f8baefaccccdc1405a9c2
Reviewed-on: http://gerrit.cloudera.org:8080/5001
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddf2e33b82002535eb1f8baefaccccdc1405a9c2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Wrong javadoc in KuduClient
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java client] Wrong javadoc in KuduClient
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddf2e33b82002535eb1f8baefaccccdc1405a9c2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No