You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by John Sichi <js...@facebook.com> on 2010/06/15 01:12:09 UTC
usage of Review Board
Hey Carl,
You mentioned to me offline last week about using Review Board for collaborative review of Hive issues, and I noticed that you started with one issue already (http://review.hbase.org/r/178/). Once we've made sure it's working smoothly, it would be cool if everyone we can get everyone using this for uniformity.
Is there a way to set Review Board up so that the infrastructure (or at least URL) is associated with Hive instead of HBase?
HBase has a note on their wiki about the process they use:
http://wiki.apache.org/hadoop/Hbase/HowToContribute#Review_Process
If we're going to institute usage of Review Board for Hive, let's document it here:
http://wiki.apache.org/hadoop/Hive/HowToContribute#Contributing_your_work
JVS
Re: usage of Review Board
Posted by Carl Steinbach <ca...@cloudera.com>.
Hi Ed,
> This seems like a good tool. Couldn't/shouldn't apache host all the
> infrastucture?
>
I totally agree. Please upvote this:
http://issues.apache.org/jira/browse/INFRA-2796
> I am not implying anything shadey is going on or anything :) but
> We do not want something like this happening
> http://www.osnews.com/comments/21921
>
In order to avoid just such a scenario Todd hacked together a script that
reposts each review comment to the original JIRA ticket on issues.apache.org
.
Thanks.
Carl
Re: usage of Review Board
Posted by Edward Capriolo <ed...@gmail.com>.
On Mon, Jun 14, 2010 at 8:35 PM, Carl Steinbach <ca...@cloudera.com> wrote:
> Hi John,
>
> You mentioned to me offline last week about using Review Board for
> > collaborative review of Hive issues, and I noticed that you started with
> one
> > issue already (http://review.hbase.org/r/178/). Once we've made sure
> it's
> > working smoothly, it would be cool if everyone we can get everyone using
> > this for uniformity.
> >
>
> Right, I was just testing this out to see if it works. I probably should
> have sent a note out to the hive-dev list first.
>
>
> >
> > Is there a way to set Review Board up so that the infrastructure (or at
> > least URL) is associated with Hive instead of HBase?
> >
> >
> I asked Todd Lipcon about this and he said that he can probably set up a
> vhost for Hive, but that will require an address, and it probably won't
> work
> seamlessly, e.g. emails will likely still refer to hbase.org. He suggested
> instead that we rename the server review.cloudera.com (which I don't think
> folks will like), or hadoopreview.org (which won't cover TLPs), or
> apachereview.org (which will probably cause problems with the ASF). Do you
> have any ideas how to solve this problem?
>
> Also, is there any chance that Facebook can host this server? We're
> currently hosting it as an EC2 instance which is kind of expensive.
>
>
>
> > HBase has a note on their wiki about the process they use:
> >
> > http://wiki.apache.org/hadoop/Hbase/HoThis seems like a good tool.
> wToContribute#Review_Process<http://wiki.apache.org/hadoop/Hbase/HowToContribute#Review_Process>
> >
> > If we're going to institute usage of Review Board for Hive, let's
> document
> > it here:
> >
> >
> http://wiki.apache.org/hadoop/Hive/HowToContribute#Contributing_your_work
> >
> >
> Sounds good to me. Should I got ahead and document it now or wait until we
> get the domain name issue resolved?
>
> Thanks.
>
> Carl
>
This seems like a good tool. Couldn't/shouldn't apache host all the
infrastucture?
I am not implying anything shadey is going on or anything :) but
We do not want something like this happening
http://www.osnews.com/comments/21921
Re: usage of Review Board
Posted by John Sichi <js...@facebook.com>.
On Jun 14, 2010, at 5:35 PM, Carl Steinbach wrote:
Hi John,
You mentioned to me offline last week about using Review Board for
collaborative review of Hive issues, and I noticed that you started with one
issue already (http://review.hbase.org/r/178/). Once we've made sure it's
working smoothly, it would be cool if everyone we can get everyone using
this for uniformity.
Right, I was just testing this out to see if it works. I probably should
have sent a note out to the hive-dev list first.
OK, I just used it for one also so I could test it out. Worked fine for me.
I asked Todd Lipcon about this and he said that he can probably set up a
vhost for Hive, but that will require an address, and it probably won't work
seamlessly, e.g. emails will likely still refer to hbase.org<http://hbase.org>. He suggested
instead that we rename the server review.cloudera.com<http://review.cloudera.com> (which I don't think
folks will like), or hadoopreview.org<http://hadoopreview.org> (which won't cover TLPs), or
apachereview.org<http://apachereview.org> (which will probably cause problems with the ASF). Do you
have any ideas how to solve this problem?
Also, is there any chance that Facebook can host this server? We're
currently hosting it as an EC2 instance which is kind of expensive.
I'm checking with Jonathan Gray to see if we can provide hosting for this (and what the best way to name it would be, since there may be some other projects like thrift and scribe that want it to).
Sounds good to me. Should I got ahead and document it now or wait until we
get the domain name issue resolved?
Add a section with a note saying that this is currently only a proposal, and then we can remove the note once everything is settled.
JVS
Re: usage of Review Board
Posted by Carl Steinbach <ca...@cloudera.com>.
Hi John,
You mentioned to me offline last week about using Review Board for
> collaborative review of Hive issues, and I noticed that you started with one
> issue already (http://review.hbase.org/r/178/). Once we've made sure it's
> working smoothly, it would be cool if everyone we can get everyone using
> this for uniformity.
>
Right, I was just testing this out to see if it works. I probably should
have sent a note out to the hive-dev list first.
>
> Is there a way to set Review Board up so that the infrastructure (or at
> least URL) is associated with Hive instead of HBase?
>
>
I asked Todd Lipcon about this and he said that he can probably set up a
vhost for Hive, but that will require an address, and it probably won't work
seamlessly, e.g. emails will likely still refer to hbase.org. He suggested
instead that we rename the server review.cloudera.com (which I don't think
folks will like), or hadoopreview.org (which won't cover TLPs), or
apachereview.org (which will probably cause problems with the ASF). Do you
have any ideas how to solve this problem?
Also, is there any chance that Facebook can host this server? We're
currently hosting it as an EC2 instance which is kind of expensive.
> HBase has a note on their wiki about the process they use:
>
> http://wiki.apache.org/hadoop/Hbase/HowToContribute#Review_Process
>
> If we're going to institute usage of Review Board for Hive, let's document
> it here:
>
> http://wiki.apache.org/hadoop/Hive/HowToContribute#Contributing_your_work
>
>
Sounds good to me. Should I got ahead and document it now or wait until we
get the domain name issue resolved?
Thanks.
Carl