You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2018/07/03 21:48:40 UTC
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10859
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
IMPALA-7202: Add width_bucket() to the decimal fuzz test
In this patch we include the newly added width_bucket() function in the
decimal fuzz test.
Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
---
M tests/query_test/test_decimal_fuzz.py
1 file changed, 57 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/10859/1
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 1:
Yeah, those should probably be merged before this change, because our build would get broken.
Alternatively, we can merge this change, but disable this test with an xfail. The test can be re-enabled in the IMPALA-7242 patch by whoever fixes the Jira.
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 00:45:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 2:
I looked at the failing query and opened IMPALA-7412.
I rewrote WidthBucketImpl() and it is under review:
http://gerrit.cloudera.org:8080/11160
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 15:30:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2950/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 23:33:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 1: Code-Review+1
Maybe some doc comments could be added to the new functions, but looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jul 2018 16:10:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2950/
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 02:46:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 1:
I saw you filed some bugs: https://issues.apache.org/jira/browse/IMPALA-7242 https://issues.apache.org/jira/browse/IMPALA-7243
Do those need to be fixed before this is merged?
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 00:33:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 1: Code-Review+1
LGTM, just need to wait for bugfixes to go in
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jul 2018 16:34:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 23:34:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/10859 )
Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test
......................................................................
Abandoned
Zoltan is taking this over.
--
To view, visit http://gerrit.cloudera.org:8080/10859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1f8a63733ebddc07f777746c525ca51ad4794dd0
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 2
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>