You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/19 14:48:37 UTC
[GitHub] [james-project] chibenwa opened a new pull request #442: JAMES-3587 Deprecate MDCBuild::addContext
chibenwa opened a new pull request #442:
URL: https://github.com/apache/james-project/pull/442
MDCBuilder::addContext does an implicit call to Object::toString
We do not want that for two reasons:
- 1. Formatting. For instance ` {"user":"btellier@erugerkuf"} ` instead
of simply `btellier@erugerkuf`.
- 2. Performance.
See the attached flame graphs: James spends ~1.20% of CPU calling
Object::toString which correlate closely to MDCBuilder::addContext.
This crosses the "valuable to optimize" threshold. Especially calls
to MoreObject::toStringHelper(this) are not negligible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #442: JAMES-3587 Deprecate MDCBuild::addContext
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #442:
URL: https://github.com/apache/james-project/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org