You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/19 08:33:57 UTC
[GitHub] [superset] villebro commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover
villebro commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762686671
> +1 on allowing saving adhoc metric in place.
>
> I think this PR looks great. Just one more thing, can we show the name (or verbose name if available) of the saved metric instead of "My metric"?
Agreed, this would be really nice. Also, showing "My Metric" for simple/custom metrics is slightly confusing as the metric will not show up as such on the chart. It might be more intuitive to show the title as it will be rendered with a dark grey color if the user hasn't provided a custom title to show what the metric will actually be called. In the screenshot below we would show "MAX(gender)" instead of "My Metric" in the title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org