You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/07/04 10:12:02 UTC

[GitHub] cordova-lib pull request #460: CB-11491 Introduce before_deploy hook

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/460#discussion_r69436735
  
    --- Diff: cordova-lib/spec-cordova/emulate.spec.js ---
    @@ -82,7 +85,7 @@ describe('emulate command', function() {
                 cordova.raw.emulate({platforms: ['ios'], options: {optionTastic: true }}).then(function(err) {
                     expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: ['ios']}));
                     expect(getPlatformApi).toHaveBeenCalledWith('ios');
    -                expect(platformApi.run).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true });
    +                expect(platformApi.run).toHaveBeenCalledWith({ device: false, emulator: true, optionTastic: true, nobuild: true });
    --- End diff --
    
    @daserge, could you please add another expectation to check if `build` also had been called and changing the options in `build` does not affect `run` command?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org