You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "cnauroth (via GitHub)" <gi...@apache.org> on 2023/03/27 23:54:24 UTC
[GitHub] [hive] cnauroth opened a new pull request, #4163: HIVE-26905: Backport HIVE-25173 to 3.2.0: Exclude pentaho-aggdesigner-algorithm from upgrade-acid build.
cnauroth opened a new pull request, #4163:
URL: https://github.com/apache/hive/pull/4163
### What changes were proposed in this pull request?
Exclude pentaho-aggdesigner-algorithm from upgrade-acid build.
### Why are the changes needed?
In the current branch-3, upgrade-acid has a dependency on an old hive-exec version that has a transitive dependency to org.pentaho:pentaho-aggdesigner-algorithm. This artifact is no longer available in commonly supported Maven repositories, which causes a build failure. We can safely exclude the dependency, as was originally done in [HIVE-25173](https://issues.apache.org/jira/browse/HIVE-25173).
Differences from the master patch branch are:
1. On master, this applied to the pre-upgrade sub-module. This sub-module doesn't exist in branch-3, so the patch was rebased to the parent upgrade-acid module.
2. Additionally, the pom.xml code had changed quite a bit on master. This is just applying the equivalent exclusion from the HIVE-25173 diff: a1d4c8a6b3cf8465ac1ae074748a8f5a04bb473f.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I can run a full local build from branch-3 after applying this patch.
```
mvn -B -T 8 clean install -Pitests -DskipTests
```
Prior to this patch, my build failed while trying to download the org.pentaho:pentaho-aggdesigner-algorithm artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #4163: HIVE-26905: Backport HIVE-25173 to 3.2.0: Exclude pentaho-aggdesigner-algorithm from upgrade-acid build.
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4163: HIVE-26905: Backport HIVE-25173 to 3.2.0: Exclude pentaho-aggdesigner-algorithm from upgrade-acid build.
URL: https://github.com/apache/hive/pull/4163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] cnauroth commented on pull request #4163: HIVE-26905: Backport HIVE-25173 to 3.2.0: Exclude pentaho-aggdesigner-algorithm from upgrade-acid build.
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on PR #4163:
URL: https://github.com/apache/hive/pull/4163#issuecomment-1486012078
Hello @zabetak . You previously approved this change in #3911 :
https://github.com/apache/hive/pull/3911#pullrequestreview-1237668110
However, I just realized it was not actually merged. Could you please take another look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org