You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/09 00:32:17 UTC
[GitHub] [incubator-mxnet] stu1130 opened a new pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
stu1130 opened a new pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676
Backport [Improvement] Invoke mkldnn and cudnn BatchNorm when axis != 1 v1.7x
The PR could be part of 1.7.1 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] pengzhao-intel commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
pengzhao-intel commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671167127
@bgawrych could you take a review for this change, especially for MKLDNN BN
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 removed a comment on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 removed a comment on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656850479
My bad I saw you fixed it Great work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych edited a comment on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
bgawrych edited a comment on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671307512
@pengzhao-intel LGTM, all test cases are executed by MKLDNN primitive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-658074546
Hi @stu1130 , I could not push the commit.
```bash
➜ incubator-mxnet git:(a273dc903) ✗ git push stu1130 stu1130/v1.7.x
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:stu1130/incubator-mxnet
! [remote rejected] stu1130/v1.7.x -> stu1130/v1.7.x (permission denied)
error: failed to push some refs to 'github.com:stu1130/incubator-mxnet'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656977216
Hi @stu1130 , the unittest test_symbol.test_load_000800 should be removed.
Meanwhile the test case of test_numpy_op.test_npx_batch_norm should be updated.
https://github.com/apache/incubator-mxnet/pull/18688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656220324
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-655826832
Hey @stu1130 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, clang, website, unix-cpu, windows-cpu, centos-cpu, edge, miscellaneous, sanity, windows-gpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] pengzhao-intel removed a comment on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
pengzhao-intel removed a comment on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671166584
Merging now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656941319
@wkcn thanks for the explanation. Let me retrigger the ci again.
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-657714443
> Hi @stu1130 , the unittest test_symbol.test_load_000800 should be removed.
> Meanwhile the test case of test_numpy_op.test_npx_batch_norm should be updated.
> #18688
>
> I do not have the permission to update this PR.
Could you check again? I enable `Allow edits and access to secrets by maintainers`
If that doesn't work out, you can create another cherry-pick PR. I can drop this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 edited a comment on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 edited a comment on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656941319
@wkcn thanks for the explanation. Let me retrigger the ci.
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671307512
@pengzhao-intel LGTM, all tests are executed by MKLDNN primitive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656850479
My bad I saw you fixed it Great work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] pengzhao-intel commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
pengzhao-intel commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671166584
Merging now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-658480114
Thanks @wkcn I will ping my colleague to merge it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671683164
Hi @stu1130 , currently, 1.7.0rc1 vote on dev@ was completed, and I didn't see any hard requirement to rework/updated the 1.7.0rc1 code base, the release process was hold on (vote on general@) to address some legal issues like (IP clearance of mshadow and some branding/trademark issue in external/3rd party usage). So I would suggest to include this in the next release, what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656941345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671705722
@ciyongch alright, I think we can do it on next release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn edited a comment on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
wkcn edited a comment on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656977216
Hi @stu1130 , the unittest test_symbol.test_load_000800 should be removed.
Meanwhile the test case of test_numpy_op.test_npx_batch_norm should be updated.
https://github.com/apache/incubator-mxnet/pull/18688
I do not have the permission to update this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656220247
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-671523168
@ciyongch if we need to rework on 1.7 source code for addressing license issue, could we include this commit? If it would block 1.7 release or affect the process, I am ok to make it release on 1.7.1 or 1.8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656938209
HI @stu1130 , the flaky test is `test_symbol.test_load_000800`.
`test_symbol.test_load_000800` initializes the weights of the model randomly, and the output's values are abnormally large, which leads to a abnormal output when invoking MKLDNN.
In the latest version of MXNet, the test `test_symbol.test_load_000800` has been removed in other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 edited a comment on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 edited a comment on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-657714443
> Hi @stu1130 , the unittest test_symbol.test_load_000800 should be removed.
> Meanwhile the test case of test_numpy_op.test_npx_batch_norm should be updated.
> #18688
>
> I do not have the permission to update this PR.
Could you check again? I enable `Allow edits and access to secrets by maintainers`
If that doesn't work out, you can create another cherry-pick PR. I can drop this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] stu1130 commented on pull request #18676: [v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 to v1.7.x
Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18676:
URL: https://github.com/apache/incubator-mxnet/pull/18676#issuecomment-656844895
@wkcn could you take a look at the nan test failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org