You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by el...@apache.org on 2008/06/09 08:47:09 UTC
svn commit: r664633 -
/mina/trunk/core/src/main/java/org/apache/mina/common/AbstractPollingIoProcessor.java
Author: elecharny
Date: Sun Jun 8 23:47:09 2008
New Revision: 664633
URL: http://svn.apache.org/viewvc?rev=664633&view=rev
Log:
o Replaced the getThreadName() method internal by some simplest code.
o Added some javadoc
Modified:
mina/trunk/core/src/main/java/org/apache/mina/common/AbstractPollingIoProcessor.java
Modified: mina/trunk/core/src/main/java/org/apache/mina/common/AbstractPollingIoProcessor.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/common/AbstractPollingIoProcessor.java?rev=664633&r1=664632&r2=664633&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/common/AbstractPollingIoProcessor.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/common/AbstractPollingIoProcessor.java Sun Jun 8 23:47:09 2008
@@ -24,13 +24,11 @@
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
-import java.util.Map;
import java.util.Queue;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.Executor;
import java.util.concurrent.atomic.AtomicInteger;
-import org.apache.mina.util.CopyOnWriteMap;
import org.apache.mina.util.NamePreservingRunnable;
/**
@@ -49,8 +47,8 @@
*/
private static final int WRITE_SPIN_COUNT = 256;
- private static final Map<Class<?>, AtomicInteger> threadIds =
- new CopyOnWriteMap<Class<?>, AtomicInteger>();
+ /** A incremental Id used for thread naming */
+ private static final AtomicInteger threadId = new AtomicInteger(0);
private final Object lock = new Object();
private final String threadName;
@@ -78,18 +76,12 @@
this.executor = executor;
}
+ /**
+ * @return a name for the current thread, based on the class name and
+ * an incremental value,starting at 1.
+ */
private String nextThreadName() {
- Class<?> cls = getClass();
- AtomicInteger threadId = threadIds.get(cls);
- int newThreadId;
- if (threadId == null) {
- newThreadId = 1;
- threadIds.put(cls, new AtomicInteger(newThreadId));
- } else {
- newThreadId = threadId.incrementAndGet();
- }
-
- return cls.getSimpleName() + '-' + newThreadId;
+ return getClass().getSimpleName() + "-" + threadId.incrementAndGet();
}
public final boolean isDisposing() {