You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "GanfengTan (via GitHub)" <gi...@apache.org> on 2023/02/08 09:24:41 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #7341: [INLONG-7339][Sort] To adjust the Sort structure for multiple versions of Apache Flink
GanfengTan opened a new pull request, #7341:
URL: https://github.com/apache/inlong/pull/7341
This improve adjusts the Sort structure for multiple versions of Apache Flink.
- Fixes #7339
### Motivation
To decouple version of Flink.
### Modifications
Move Sort Connectors
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "yunqingmoswu (via GitHub)" <gi...@apache.org>.
yunqingmoswu commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1105450566
##########
inlong-sort/sort-flink/v1.13/sort-connectors/redis/pom.xml:
##########
@@ -139,7 +139,9 @@
<includes>
<include>org/apache/inlong/**</include>
<include>META-INF/services/org.apache.flink.table.factories.Factory</include>
- <include>META-INF/services/org.apache.flink.streaming.connectors.redis.common.hanlder.RedisHandler</include>
+ <include>
Review Comment:
Please don't update the format of it.
##########
inlong-sort/sort-flink/v1.13/sort-connectors/base/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory:
##########
@@ -13,5 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-org.apache.inlong.sort.base.dirty.sink.log.LogDirtySinkFactory
+org.apache.inlong.sort.base.dirty.sink.logset.LogDirtySinkFactory
Review Comment:
Makesure it is right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1430705291
> `sort-dist`, `sort-format` and `sort-core` need add version directory.
I think it's better to reuse more modules and functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1430702237
> after renaming the directory of `sort-connectors`, I think we need to change the `sort-connectors.xml` at the same time.
done @dockerzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1106608473
##########
inlong-sort/sort-flink/v1.13/sort-connectors/base/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory:
##########
@@ -13,5 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-org.apache.inlong.sort.base.dirty.sink.log.LogDirtySinkFactory
+org.apache.inlong.sort.base.dirty.sink.logset.LogDirtySinkFactory
Review Comment:
It is recommended that the names of subsequent files not conflict with the gitignore contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1105440553
##########
inlong-sort/sort-flink/v1.13/pom.xml:
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>sort-flink</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>v1.13</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Apache InLong - Sort-flink-v1.13</name>
Review Comment:
```suggestion
<name>Apache InLong - Sort Flink v1.13</name>
```
##########
inlong-sort/sort-flink/pom.xml:
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-sort</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>sort-flink</artifactId>
+ <packaging>pom</packaging>
+ <name>Apache InLong - Sort-flink</name>
+ <modules>
+ <module>v1.13</module>
Review Comment:
```suggestion
<module>sort-flink-v1.13</module>
```
##########
inlong-sort/sort-flink/v1.13/pom.xml:
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>sort-flink</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>v1.13</artifactId>
Review Comment:
```suggestion
<artifactId>sort-flink-v1.13</artifactId>
```
##########
inlong-sort/pom.xml:
##########
@@ -35,10 +35,10 @@
<module>sort-api</module>
<module>sort-common</module>
<module>sort-formats</module>
- <module>sort-connectors</module>
<module>sort-core</module>
<module>sort-dist</module>
<module>sort-end-to-end-tests</module>
+ <module>sort-flink</module>
Review Comment:
please move the `sort-flink` before `sort-dist`.
##########
inlong-sort/sort-flink/pom.xml:
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-sort</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>sort-flink</artifactId>
+ <packaging>pom</packaging>
+ <name>Apache InLong - Sort-flink</name>
Review Comment:
```suggestion
<name>Apache InLong - Sort Flink</name>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1429324024
@GanfengTan after renaming the directory of sort-connectors, I think we need to change the `sort-connectors.xml` at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1430812335
> I think it's better to reuse more modules and functions.
+1 @dockerzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1106013906
##########
inlong-sort/sort-flink/pom.xml:
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-sort</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>sort-flink</artifactId>
+ <packaging>pom</packaging>
+ <name>Apache InLong - Sort-flink</name>
+ <modules>
+ <module>v1.13</module>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7341: [INLONG-7339][Sort] To adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1423962861
@GanfengTan please add the plan detail about how to support multiple versions of Apache Flink, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1106000133
##########
inlong-sort/sort-flink/v1.13/pom.xml:
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>sort-flink</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>v1.13</artifactId>
Review Comment:
done
##########
inlong-sort/sort-flink/v1.13/pom.xml:
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>sort-flink</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>v1.13</artifactId>
+ <packaging>pom</packaging>
+
+ <name>Apache InLong - Sort-flink-v1.13</name>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1430701838
> `sort-dist`, `sort-format` and `sort-core` need add version directory.
You are correct, this involves a global Flink version change, a dedicated PR will be created to fix.
Will add PR information to your comment.
Thank you very much @gong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7341:
URL: https://github.com/apache/inlong/pull/7341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7341: [INLONG-7339][Sort] To adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1423963804
@featzhang PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1429310333
@GanfengTan you can run `mvn spotless:apply` to fix the format error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1106013538
##########
inlong-sort/sort-flink/pom.xml:
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-sort</artifactId>
+ <version>1.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>sort-flink</artifactId>
+ <packaging>pom</packaging>
+ <name>Apache InLong - Sort-flink</name>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1106015500
##########
inlong-sort/pom.xml:
##########
@@ -35,10 +35,10 @@
<module>sort-api</module>
<module>sort-common</module>
<module>sort-formats</module>
- <module>sort-connectors</module>
<module>sort-core</module>
<module>sort-dist</module>
<module>sort-end-to-end-tests</module>
+ <module>sort-flink</module>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #7341:
URL: https://github.com/apache/inlong/pull/7341#discussion_r1106111746
##########
inlong-sort/sort-flink/v1.13/sort-connectors/base/src/main/resources/META-INF/services/org.apache.flink.table.factories.Factory:
##########
@@ -13,5 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-org.apache.inlong.sort.base.dirty.sink.log.LogDirtySinkFactory
+org.apache.inlong.sort.base.dirty.sink.logset.LogDirtySinkFactory
Review Comment:
done
##########
inlong-sort/sort-flink/v1.13/sort-connectors/redis/pom.xml:
##########
@@ -139,7 +139,9 @@
<includes>
<include>org/apache/inlong/**</include>
<include>META-INF/services/org.apache.flink.table.factories.Factory</include>
- <include>META-INF/services/org.apache.flink.streaming.connectors.redis.common.hanlder.RedisHandler</include>
+ <include>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #7341: [INLONG-7339][Sort] Adjust the Sort structure for multiple versions of Apache Flink
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7341:
URL: https://github.com/apache/inlong/pull/7341#issuecomment-1430678075
`sort-dist`, `sort-format` and `sort-core` need add version directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org