[GitHub] [knox] moresandeep commented on a change in pull request #353: Knox 2344

[GitBox <gi...@apache.org>]

moresandeep commented on a change in pull request #353:
URL: https://github.com/apache/knox/pull/353#discussion_r444113547



##########
File path: gateway-release/pom.xml
##########
@@ -439,7 +439,7 @@
         </dependency>
         <dependency>
             <groupId>org.apache.knox</groupId>
-            <artifactId>gateway-cm-integration</artifactId>
+            <artifactId>gateway-topology-hadoopxml</artifactId>

Review comment:
       nit: since hadoop and xml are two different words do you think the name `gateway-topology-hadoop-xml` is more appropriate? it does look a bit long and awkward though.

##########
File path: gateway-topology-hadoopxml/pom.xml
##########
@@ -25,9 +25,9 @@
         <version>1.5.0-SNAPSHOT</version>
     </parent>
 
-    <artifactId>gateway-cm-integration</artifactId>
-    <name>gateway-cm-integration</name>
-    <description>Cloudera Manager integration related resources</description>
+    <artifactId>gateway-topology-hadoopxml</artifactId>
+    <name>gateway-topology-hadoopxml</name>

Review comment:
       Same nit as above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org