You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/21 09:42:57 UTC

[GitHub] [kafka] chia7712 opened a new pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

chia7712 opened a new pull request #9469:
URL: https://github.com/apache/kafka/pull/9469


   This PR includes two changes.
   
   1. replace FetchRequest.TopicAndPartitionData by Map.Entry (to reduce duplicate code)
   1. move ```batchByTopic``` to ```FetchResponse``` 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9469:
URL: https://github.com/apache/kafka/pull/9469#issuecomment-717207972


   @ijuma Thanks for your comment. close it due to the bad refactor :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 closed pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #9469:
URL: https://github.com/apache/kafka/pull/9469


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9469: MINOR: replace FetchRequest.TopicAndPartitionData by Map.Entry

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9469:
URL: https://github.com/apache/kafka/pull/9469#issuecomment-714728901


   Thanks for the PR. Is this an improvement? It seems to make the code harder to read.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org