[GitHub] mhenke1 commented on a change in pull request #2968: add additional metrics and logs

[GitBox <gi...@apache.org>]

mhenke1 commented on a change in pull request #2968: add additional metrics and logs
URL: https://github.com/apache/incubator-openwhisk/pull/2968#discussion_r155475020
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -78,27 +76,56 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
     }
   }
 
+  def logContainerStart(r: Run, containerState: String): Unit = {
+    val namespaceName = r.msg.user.namespace.name
+    val actionName = r.action.name.name
+    val activationId = r.msg.activationId.toString
+
+    logging.info(
+      this,
+      s"containerStart containerState: $containerState action: $actionName namespace: $namespaceName activationId: $activationId")(
+      r.msg.transid)
+    MetricEmitter.emitCounterMetric(LoggingMarkers.INVOKER_CONTAINER_START(actionName, namespaceName, containerState))
+  }
 
 Review comment:
   Code evolvement reasons. We added the logging out output late (and with it the transaction id) and did no realize that we now were able to merge the two things using txid.mark. Corrected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services