You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/02/05 04:41:52 UTC
Review Request 17732: The result of show grant / show role should be tabular
format
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17732/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6204
https://issues.apache.org/jira/browse/HIVE-6204
Repository: hive-git
Description
-------
{noformat}
hive> show grant role role1 on all;
OK
database default
table src
principalName role1
principalType ROLE
privilege Create
grantTime Wed Dec 18 14:17:56 KST 2013
grantor navis
database default
table srcpart
principalName role1
principalType ROLE
privilege Update
grantTime Wed Dec 18 14:18:28 KST 2013
grantor navis
{noformat}
This should be something like below, especially for JDBC clients.
{noformat}
hive> show grant role role1 on all;
OK
default src role1 ROLE Create false 1387343876000 navis
default srcpart role1 ROLE Update false 1387343908000 navis
{noformat}
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 89c9349
data/conf/hive-site.xml 88f3bda
metastore/if/hive_metastore.thrift e327e2a
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a17bbf7
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp eedce50
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 35fcf58
metastore/src/gen/thrift/gen-php/metastore/Types.php dc914a5
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 6abfad4
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 5e12ef7
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 2d8e483
ql/src/java/org/apache/hadoop/hive/ql/Context.java 9f7fd5d
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a926f1e
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f4d9a83
ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java de323a9
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java de59ec3
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java adbd1a8
ql/src/test/results/clientnegative/authorization_fail_3.q.out 10df438
ql/src/test/results/clientnegative/authorization_fail_4.q.out 91ecbe9
ql/src/test/results/clientnegative/authorization_fail_5.q.out 7c70c66
ql/src/test/results/clientnegative/authorization_fail_7.q.out 7bfb6e6
ql/src/test/results/clientnegative/authorization_part.q.out 08866b4
ql/src/test/results/clientpositive/authorization_1.q.out 3391bcd
ql/src/test/results/clientpositive/authorization_1_sql_std.q.out a0b1ce0
ql/src/test/results/clientpositive/authorization_2.q.out 5b29855
ql/src/test/results/clientpositive/authorization_3.q.out ff42dfb
ql/src/test/results/clientpositive/authorization_4.q.out e656213
ql/src/test/results/clientpositive/authorization_5.q.out 3aeaeca
ql/src/test/results/clientpositive/authorization_6.q.out 0d555e4
ql/src/test/results/clientpositive/authorization_9.q.out bad418c
ql/src/test/results/clientpositive/authorization_role_grant1.q.out 981060f
ql/src/test/results/clientpositive/authorization_view.q.out 23a1c0b
Diff: https://reviews.apache.org/r/17732/diff/
Testing
-------
Thanks,
Navis Ryu
Re: Review Request 17732: The result of show grant / show role should be
tabular format
Posted by Navis Ryu <na...@nexr.com>.
> On Feb. 6, 2014, 8:24 a.m., Thejas Nair wrote:
> > metastore/if/hive_metastore.thrift, line 110
> > <https://reviews.apache.org/r/17732/diff/1/?file=469745#file469745line110>
> >
> > I assume you are adding these fields for the functionality of 'describe role <rolename>' where you get all users who belong to a role and their grant information. Is that correct?
> > Maybe we should put a comment in this file saying this part of role privilege description (not fields to be passed while creating a role). (Another approach to consider would be to have these new fields in a separate list field within Role).
You are right. I've missed that. I prefer to add comments rather than additional thrift class. How about you?
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17732/#review33775
-----------------------------------------------------------
On Feb. 6, 2014, 8:22 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17732/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 8:22 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6204
> https://issues.apache.org/jira/browse/HIVE-6204
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> {noformat}
> hive> show grant role role1 on all;
> OK
> database default
> table src
> principalName role1
> principalType ROLE
> privilege Create
> grantTime Wed Dec 18 14:17:56 KST 2013
> grantor navis
> database default
> table srcpart
> principalName role1
> principalType ROLE
> privilege Update
> grantTime Wed Dec 18 14:18:28 KST 2013
> grantor navis
> {noformat}
>
> This should be something like below, especially for JDBC clients.
> {noformat}
> hive> show grant role role1 on all;
> OK
> default src role1 ROLE Create false 1387343876000 navis
> default srcpart role1 ROLE Update false 1387343908000 navis
> {noformat}
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ad3d59c
> data/conf/hive-site.xml 88f3bda
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 11db3fd
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 74fd53f
> jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 50207dc
> metastore/if/hive_metastore.thrift e327e2a
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a17bbf7
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp eedce50
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 35fcf58
> metastore/src/gen/thrift/gen-php/metastore/Types.php dc914a5
> metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 6abfad4
> metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 5e12ef7
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ddc6aed
> ql/src/java/org/apache/hadoop/hive/ql/Context.java 9f7fd5d
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a926f1e
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f4d9a83
> ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java de323a9
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java de59ec3
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java adbd1a8
> ql/src/test/results/clientnegative/authorization_fail_3.q.out 10df438
> ql/src/test/results/clientnegative/authorization_fail_4.q.out 91ecbe9
> ql/src/test/results/clientnegative/authorization_fail_5.q.out 7c70c66
> ql/src/test/results/clientnegative/authorization_fail_7.q.out 1f72cff
> ql/src/test/results/clientnegative/authorization_part.q.out 08866b4
> ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out eea2cb3
> ql/src/test/results/clientpositive/authorization_1.q.out 58ec8ec
> ql/src/test/results/clientpositive/authorization_1_sql_std.q.out e7d4b90
> ql/src/test/results/clientpositive/authorization_2.q.out 5b29855
> ql/src/test/results/clientpositive/authorization_3.q.out ff42dfb
> ql/src/test/results/clientpositive/authorization_4.q.out e656213
> ql/src/test/results/clientpositive/authorization_5.q.out e4914c9
> ql/src/test/results/clientpositive/authorization_6.q.out 0d555e4
> ql/src/test/results/clientpositive/authorization_9.q.out bad418c
> ql/src/test/results/clientpositive/authorization_role_grant1.q.out cd53ca3
> ql/src/test/results/clientpositive/authorization_view.q.out a872ce8
>
> Diff: https://reviews.apache.org/r/17732/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 17732: The result of show grant / show role should be
tabular format
Posted by Thejas Nair <th...@hortonworks.com>.
> On Feb. 6, 2014, 8:24 a.m., Thejas Nair wrote:
> > metastore/if/hive_metastore.thrift, line 110
> > <https://reviews.apache.org/r/17732/diff/1/?file=469745#file469745line110>
> >
> > I assume you are adding these fields for the functionality of 'describe role <rolename>' where you get all users who belong to a role and their grant information. Is that correct?
> > Maybe we should put a comment in this file saying this part of role privilege description (not fields to be passed while creating a role). (Another approach to consider would be to have these new fields in a separate list field within Role).
>
> Navis Ryu wrote:
> You are right. I've missed that. I prefer to add comments rather than additional thrift class. How about you?
Adding the comments are fine with me.
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17732/#review33775
-----------------------------------------------------------
On Feb. 6, 2014, 8:22 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17732/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 8:22 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6204
> https://issues.apache.org/jira/browse/HIVE-6204
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> {noformat}
> hive> show grant role role1 on all;
> OK
> database default
> table src
> principalName role1
> principalType ROLE
> privilege Create
> grantTime Wed Dec 18 14:17:56 KST 2013
> grantor navis
> database default
> table srcpart
> principalName role1
> principalType ROLE
> privilege Update
> grantTime Wed Dec 18 14:18:28 KST 2013
> grantor navis
> {noformat}
>
> This should be something like below, especially for JDBC clients.
> {noformat}
> hive> show grant role role1 on all;
> OK
> default src role1 ROLE Create false 1387343876000 navis
> default srcpart role1 ROLE Update false 1387343908000 navis
> {noformat}
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ad3d59c
> data/conf/hive-site.xml 88f3bda
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 11db3fd
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 74fd53f
> jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 50207dc
> metastore/if/hive_metastore.thrift e327e2a
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a17bbf7
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp eedce50
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 35fcf58
> metastore/src/gen/thrift/gen-php/metastore/Types.php dc914a5
> metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 6abfad4
> metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 5e12ef7
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ddc6aed
> ql/src/java/org/apache/hadoop/hive/ql/Context.java 9f7fd5d
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a926f1e
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f4d9a83
> ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java de323a9
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java de59ec3
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java adbd1a8
> ql/src/test/results/clientnegative/authorization_fail_3.q.out 10df438
> ql/src/test/results/clientnegative/authorization_fail_4.q.out 91ecbe9
> ql/src/test/results/clientnegative/authorization_fail_5.q.out 7c70c66
> ql/src/test/results/clientnegative/authorization_fail_7.q.out 1f72cff
> ql/src/test/results/clientnegative/authorization_part.q.out 08866b4
> ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out eea2cb3
> ql/src/test/results/clientpositive/authorization_1.q.out 58ec8ec
> ql/src/test/results/clientpositive/authorization_1_sql_std.q.out e7d4b90
> ql/src/test/results/clientpositive/authorization_2.q.out 5b29855
> ql/src/test/results/clientpositive/authorization_3.q.out ff42dfb
> ql/src/test/results/clientpositive/authorization_4.q.out e656213
> ql/src/test/results/clientpositive/authorization_5.q.out e4914c9
> ql/src/test/results/clientpositive/authorization_6.q.out 0d555e4
> ql/src/test/results/clientpositive/authorization_9.q.out bad418c
> ql/src/test/results/clientpositive/authorization_role_grant1.q.out cd53ca3
> ql/src/test/results/clientpositive/authorization_view.q.out a872ce8
>
> Diff: https://reviews.apache.org/r/17732/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 17732: The result of show grant / show role should be
tabular format
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17732/#review33775
-----------------------------------------------------------
metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/17732/#comment63397>
I assume you are adding these fields for the functionality of 'describe role <rolename>' where you get all users who belong to a role and their grant information. Is that correct?
Maybe we should put a comment in this file saying this part of role privilege description (not fields to be passed while creating a role). (Another approach to consider would be to have these new fields in a separate list field within Role).
- Thejas Nair
On Feb. 6, 2014, 8:22 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17732/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 8:22 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6204
> https://issues.apache.org/jira/browse/HIVE-6204
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> {noformat}
> hive> show grant role role1 on all;
> OK
> database default
> table src
> principalName role1
> principalType ROLE
> privilege Create
> grantTime Wed Dec 18 14:17:56 KST 2013
> grantor navis
> database default
> table srcpart
> principalName role1
> principalType ROLE
> privilege Update
> grantTime Wed Dec 18 14:18:28 KST 2013
> grantor navis
> {noformat}
>
> This should be something like below, especially for JDBC clients.
> {noformat}
> hive> show grant role role1 on all;
> OK
> default src role1 ROLE Create false 1387343876000 navis
> default srcpart role1 ROLE Update false 1387343908000 navis
> {noformat}
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ad3d59c
> data/conf/hive-site.xml 88f3bda
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 11db3fd
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 74fd53f
> jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 50207dc
> metastore/if/hive_metastore.thrift e327e2a
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a17bbf7
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp eedce50
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 35fcf58
> metastore/src/gen/thrift/gen-php/metastore/Types.php dc914a5
> metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 6abfad4
> metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 5e12ef7
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ddc6aed
> ql/src/java/org/apache/hadoop/hive/ql/Context.java 9f7fd5d
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a926f1e
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f4d9a83
> ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java de323a9
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java de59ec3
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java adbd1a8
> ql/src/test/results/clientnegative/authorization_fail_3.q.out 10df438
> ql/src/test/results/clientnegative/authorization_fail_4.q.out 91ecbe9
> ql/src/test/results/clientnegative/authorization_fail_5.q.out 7c70c66
> ql/src/test/results/clientnegative/authorization_fail_7.q.out 1f72cff
> ql/src/test/results/clientnegative/authorization_part.q.out 08866b4
> ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out eea2cb3
> ql/src/test/results/clientpositive/authorization_1.q.out 58ec8ec
> ql/src/test/results/clientpositive/authorization_1_sql_std.q.out e7d4b90
> ql/src/test/results/clientpositive/authorization_2.q.out 5b29855
> ql/src/test/results/clientpositive/authorization_3.q.out ff42dfb
> ql/src/test/results/clientpositive/authorization_4.q.out e656213
> ql/src/test/results/clientpositive/authorization_5.q.out e4914c9
> ql/src/test/results/clientpositive/authorization_6.q.out 0d555e4
> ql/src/test/results/clientpositive/authorization_9.q.out bad418c
> ql/src/test/results/clientpositive/authorization_role_grant1.q.out cd53ca3
> ql/src/test/results/clientpositive/authorization_view.q.out a872ce8
>
> Diff: https://reviews.apache.org/r/17732/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 17732: The result of show grant / show role should be
tabular format
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17732/#review33780
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Feb. 6, 2014, 8:22 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17732/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 8:22 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6204
> https://issues.apache.org/jira/browse/HIVE-6204
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> {noformat}
> hive> show grant role role1 on all;
> OK
> database default
> table src
> principalName role1
> principalType ROLE
> privilege Create
> grantTime Wed Dec 18 14:17:56 KST 2013
> grantor navis
> database default
> table srcpart
> principalName role1
> principalType ROLE
> privilege Update
> grantTime Wed Dec 18 14:18:28 KST 2013
> grantor navis
> {noformat}
>
> This should be something like below, especially for JDBC clients.
> {noformat}
> hive> show grant role role1 on all;
> OK
> default src role1 ROLE Create false 1387343876000 navis
> default srcpart role1 ROLE Update false 1387343908000 navis
> {noformat}
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ad3d59c
> data/conf/hive-site.xml 88f3bda
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 11db3fd
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 74fd53f
> jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 50207dc
> metastore/if/hive_metastore.thrift e327e2a
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a17bbf7
> metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp eedce50
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 35fcf58
> metastore/src/gen/thrift/gen-php/metastore/Types.php dc914a5
> metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 6abfad4
> metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 5e12ef7
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ddc6aed
> ql/src/java/org/apache/hadoop/hive/ql/Context.java 9f7fd5d
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a926f1e
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f4d9a83
> ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java de323a9
> ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java de59ec3
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java adbd1a8
> ql/src/test/results/clientnegative/authorization_fail_3.q.out 10df438
> ql/src/test/results/clientnegative/authorization_fail_4.q.out 91ecbe9
> ql/src/test/results/clientnegative/authorization_fail_5.q.out 7c70c66
> ql/src/test/results/clientnegative/authorization_fail_7.q.out 1f72cff
> ql/src/test/results/clientnegative/authorization_part.q.out 08866b4
> ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out eea2cb3
> ql/src/test/results/clientpositive/authorization_1.q.out 58ec8ec
> ql/src/test/results/clientpositive/authorization_1_sql_std.q.out e7d4b90
> ql/src/test/results/clientpositive/authorization_2.q.out 5b29855
> ql/src/test/results/clientpositive/authorization_3.q.out ff42dfb
> ql/src/test/results/clientpositive/authorization_4.q.out e656213
> ql/src/test/results/clientpositive/authorization_5.q.out e4914c9
> ql/src/test/results/clientpositive/authorization_6.q.out 0d555e4
> ql/src/test/results/clientpositive/authorization_9.q.out bad418c
> ql/src/test/results/clientpositive/authorization_role_grant1.q.out cd53ca3
> ql/src/test/results/clientpositive/authorization_view.q.out a872ce8
>
> Diff: https://reviews.apache.org/r/17732/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
Re: Review Request 17732: The result of show grant / show role should be
tabular format
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17732/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 8:22 a.m.)
Review request for hive.
Changes
-------
1. Rebased to trunk
2. Fixed test skip of TestJdbcDriver2#testShowGrant, etc.
3. Fix 'null' string for null entry (now returns empty string)
Bugs: HIVE-6204
https://issues.apache.org/jira/browse/HIVE-6204
Repository: hive-git
Description
-------
{noformat}
hive> show grant role role1 on all;
OK
database default
table src
principalName role1
principalType ROLE
privilege Create
grantTime Wed Dec 18 14:17:56 KST 2013
grantor navis
database default
table srcpart
principalName role1
principalType ROLE
privilege Update
grantTime Wed Dec 18 14:18:28 KST 2013
grantor navis
{noformat}
This should be something like below, especially for JDBC clients.
{noformat}
hive> show grant role role1 on all;
OK
default src role1 ROLE Create false 1387343876000 navis
default srcpart role1 ROLE Update false 1387343908000 navis
{noformat}
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ad3d59c
data/conf/hive-site.xml 88f3bda
itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 11db3fd
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 74fd53f
jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 50207dc
metastore/if/hive_metastore.thrift e327e2a
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a17bbf7
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp eedce50
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java 35fcf58
metastore/src/gen/thrift/gen-php/metastore/Types.php dc914a5
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 6abfad4
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 5e12ef7
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ddc6aed
ql/src/java/org/apache/hadoop/hive/ql/Context.java 9f7fd5d
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a926f1e
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f4d9a83
ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java de323a9
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java de59ec3
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java adbd1a8
ql/src/test/results/clientnegative/authorization_fail_3.q.out 10df438
ql/src/test/results/clientnegative/authorization_fail_4.q.out 91ecbe9
ql/src/test/results/clientnegative/authorization_fail_5.q.out 7c70c66
ql/src/test/results/clientnegative/authorization_fail_7.q.out 1f72cff
ql/src/test/results/clientnegative/authorization_part.q.out 08866b4
ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out eea2cb3
ql/src/test/results/clientpositive/authorization_1.q.out 58ec8ec
ql/src/test/results/clientpositive/authorization_1_sql_std.q.out e7d4b90
ql/src/test/results/clientpositive/authorization_2.q.out 5b29855
ql/src/test/results/clientpositive/authorization_3.q.out ff42dfb
ql/src/test/results/clientpositive/authorization_4.q.out e656213
ql/src/test/results/clientpositive/authorization_5.q.out e4914c9
ql/src/test/results/clientpositive/authorization_6.q.out 0d555e4
ql/src/test/results/clientpositive/authorization_9.q.out bad418c
ql/src/test/results/clientpositive/authorization_role_grant1.q.out cd53ca3
ql/src/test/results/clientpositive/authorization_view.q.out a872ce8
Diff: https://reviews.apache.org/r/17732/diff/
Testing
-------
Thanks,
Navis Ryu