You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Jarek Jarcec Cecho (Created) (JIRA)" <ji...@apache.org> on 2011/11/17 19:35:51 UTC
[jira] [Created] (SQOOP-393) Class SqoopOptions was not properly
moved
Class SqoopOptions was not properly moved
-----------------------------------------
Key: SQOOP-393
URL: https://issues.apache.org/jira/browse/SQOOP-393
Project: Sqoop
Issue Type: Bug
Affects Versions: 1.4.0-incubating
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152220#comment-13152220 ]
jiraposter@reviews.apache.org commented on SQOOP-393:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/
-----------------------------------------------------------
(Updated 2011-11-17 18:47:44.428152)
Review request for Sqoop and Arvind Prabhakar.
Changes
-------
Fixed checkstyle violations.
Summary
-------
I've moved the functionality like we did with other classes.
This addresses bug SQOOP-393.
https://issues.apache.org/jira/browse/SQOOP-393
Diffs (updated)
-----
/src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
/src/java/org/apache/sqoop/SqoopOptions.java 1201319
Diff: https://reviews.apache.org/r/2874/diff
Testing
-------
I've passed basic tests.
Thanks,
Jarek
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-393:
-------------------------------------
Attachment: SQOOP-393.patch
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-393.patch
>
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-393:
-------------------------------------
Status: Patch Available (was: Open)
I've moved the SqoopOptions class functionality as we did with other classes.
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-393.patch
>
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152436#comment-13152436 ]
jiraposter@reviews.apache.org commented on SQOOP-393:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/#review3334
-----------------------------------------------------------
Ship it!
+1
Thanks for the patch Jarcec. Please attach the patch to the JIRA for commit.
- Arvind
On 2011-11-17 18:47:44, Jarek Jarcec wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2874/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-17 18:47:44)
bq.
bq.
bq. Review request for Sqoop and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've moved the functionality like we did with other classes.
bq.
bq.
bq. This addresses bug SQOOP-393.
bq. https://issues.apache.org/jira/browse/SQOOP-393
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
bq. /src/java/org/apache/sqoop/SqoopOptions.java 1201319
bq.
bq. Diff: https://reviews.apache.org/r/2874/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I've passed basic tests.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated SQOOP-393:
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.1-incubating
Status: Resolved (was: Patch Available)
Patch committed. Thanks Jarcec.
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.4.1-incubating
>
> Attachments: SQOOP-393.patch
>
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152201#comment-13152201 ]
jiraposter@reviews.apache.org commented on SQOOP-393:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/
-----------------------------------------------------------
Review request for Sqoop and Arvind Prabhakar.
Summary
-------
I've moved the functionality like we did with other classes.
This addresses bug SQOOP-393.
https://issues.apache.org/jira/browse/SQOOP-393
Diffs
-----
/src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
/src/java/org/apache/sqoop/SqoopOptions.java 1201319
Diff: https://reviews.apache.org/r/2874/diff
Testing
-------
I've passed basic tests.
Thanks,
Jarek
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-393) Class SqoopOptions was not properly
moved
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153003#comment-13153003 ]
Hudson commented on SQOOP-393:
------------------------------
Integrated in Sqoop-jdk-1.6 #63 (See [https://builds.apache.org/job/Sqoop-jdk-1.6/63/])
SQOOP-393. Class SqoopOptions was not properly moved.
(Jarek Jarcec via Arvind Prabhakar)
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1203759
Files :
* /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/SqoopOptions.java
* /incubator/sqoop/trunk/src/java/org/apache/sqoop/SqoopOptions.java
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.4.1-incubating
>
> Attachments: SQOOP-393.patch
>
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira