You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Alex Parvulescu (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 12:10:22 UTC

[jira] [Created] (JCR-3268) Re-index fails on corrupt bundle

Re-index fails on corrupt bundle
--------------------------------

                 Key: JCR-3268
                 URL: https://issues.apache.org/jira/browse/JCR-3268
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: indexing, jackrabbit-core
            Reporter: Alex Parvulescu


The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Claus Köll (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235507#comment-13235507 ] 

Claus Köll commented on JCR-3268:
---------------------------------

Is this not be handled with JCR-2651
greets
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Alex Parvulescu (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu resolved JCR-3268.
----------------------------------

    Resolution: Fixed

fixed in revision 1304323.
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Claus Köll (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235528#comment-13235528 ] 

Claus Köll commented on JCR-3268:
---------------------------------

ahh sorry for my typo .. 
ok i see you are handling with ItemStateException... so i think it will be good as you have proposed to catch it and handle it with OnWorkspaceInconsistency#logError
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Marcel Reutegger (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235572#comment-13235572 ] 

Marcel Reutegger commented on JCR-3268:
---------------------------------------

> wrap log.error into a public method OnWorkspaceInconsistency#logError

sounds good to me.
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu updated JCR-3268:
---------------------------------

    Fix Version/s: 2.6
    
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>             Fix For: 2.6
>
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235511#comment-13235511 ] 

Alex Parvulescu commented on JCR-3268:
--------------------------------------

Hi Claus, I don't understand what you are saying :)
Is that a question or a suggestion?

It is not currently handled by JCR-2651 because it addresses only NoSuchItemStateException. 
In this issue I'm dealing with is an ItemStateException generated by a corrupt bundle.
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu updated JCR-3268:
---------------------------------

    Fix Version/s: 2.4.1
         Assignee: Alex Parvulescu
    
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 2.4.1, 2.6
>
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235504#comment-13235504 ] 

Alex Parvulescu commented on JCR-3268:
--------------------------------------

In the case of a corrupt bundle the ItemStateManager#getItemState can throw an ItemStateException that stops the repository from starting.

My proposal is to have MultiIndex.createInitialIndex catch the ItemStateException and have it logged via the OnWorkspaceInconsistency handler.
The error wouldn't be a blocker anymore and if anybody is looking at the workspace consystency logs will see its message as well.

The simplest way to do this is to wrap log.error into a public method OnWorkspaceInconsistency#logError and use it from the MultiIndex.
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-3268:
-------------------------------

    Fix Version/s:     (was: 2.6)
                   2.5
    
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 2.4.1, 2.5
>
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3268) Re-index fails on corrupt bundle

Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236751#comment-13236751 ] 

Alex Parvulescu commented on JCR-3268:
--------------------------------------

backported to 2.4 in revision 1304466.
                
> Re-index fails on corrupt bundle
> --------------------------------
>
>                 Key: JCR-3268
>                 URL: https://issues.apache.org/jira/browse/JCR-3268
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>            Reporter: Alex Parvulescu
>             Fix For: 2.4.1, 2.6
>
>
> The re-indexing process should be more resilient, log an error and simply continue with the next node. It doesn't seem useful to refuse repository startup in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira