You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/05/28 14:34:58 UTC
Review Request 70733: Added `==` and `!=` operators to
`ResourceLimits`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70733/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Added `==` and `!=` operators to `ResourceLimits`.
Diffs
-----
src/common/resource_quantities.hpp 21f08c6114de4f8459c0a5f7e25d7b6bba0f060b
src/common/resource_quantities.cpp eb741e36669da4ebd1936c1d9caf7266b6105dbb
Diff: https://reviews.apache.org/r/70733/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70733: Added `==` and `!=` operators to
`ResourceLimits`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70733/#review215539
-----------------------------------------------------------
Ship it!
Can you expand the description about when this is used? It's not obvious to me. I can imagine tests might want to compare them?
- Benjamin Mahler
On May 28, 2019, 2:34 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70733/
> -----------------------------------------------------------
>
> (Updated May 28, 2019, 2:34 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `==` and `!=` operators to `ResourceLimits`.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 21f08c6114de4f8459c0a5f7e25d7b6bba0f060b
> src/common/resource_quantities.cpp eb741e36669da4ebd1936c1d9caf7266b6105dbb
>
>
> Diff: https://reviews.apache.org/r/70733/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>