You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2010/01/19 16:56:24 UTC

DO NOT REPLY [Bug 48573] New: LDAPExtSampler directory context handling

https://issues.apache.org/bugzilla/show_bug.cgi?id=48573

           Summary: LDAPExtSampler directory context handling
           Product: JMeter
           Version: 2.3.4
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: PatchAvailable
          Severity: normal
          Priority: P2
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: rainer.jung@kippdata.de


Created an attachment (id=24860)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24860)
Patch against trunk r900635

LdapExtSampler has two Hashtables: ldapContexts and ldapConnections. One should
cache DirContext instances per thread, the other LDAPExtClient instances.

But inspection of the class LDAPExtClient shows, that all of it's method can be
declared static. All data needed is always passed in as method arguments. So
there's no need to use a Hashtable of instances. Also: the ldapConnections
Hashtable wasn't filled correctly. So let's turn to static methods and remove
the Hashtable.

It seems the ext ldap sampler was broken for more complex bind, search, unbind
tests and at least those work with the patch applied.

Patch is against trunk, but the same situation occurs in 2.3.4.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 48573] LDAPExtSampler directory context handling

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48573

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Sebb <se...@apache.org> 2010-01-20 15:52:21 UTC ---
Good catch:

URL: http://svn.apache.org/viewvc?rev=901444&view=rev
Log:
Bug 48573 - LDAPExtSampler directory context handling

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org