You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "haohuaijin (via GitHub)" <gi...@apache.org> on 2026/10/18 13:53:43 UTC

[PR] refactor(parquet): simplify `expand_to_batch_boundaries_from_selectors` [arrow-rs]

haohuaijin opened a new pull request, #11684:
URL: https://github.com/apache/arrow-rs/pull/11684

   # Which issue does this PR close?
   
   <!--
   It is not necessary to raise an issue, but it is encouraged if it is a non-trivial
   enhancement/bug.
   
   If this PR relates to an existing issue, but does not fully resolve it, please change
   the wording below from "Closes #NNN" to "Relates to #NNN" or "Part of #NNN" to avoid
   false closing an issue.
   -->
   
   - Closes #NNN
   
   # Rationale for this change
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the
   issue then this section is not needed. Explaining clearly why changes are proposed
   helps reviewers understand your changes and offer better suggestions for fixes.
   
   Please try to explain the problem you are trying to solve in terms of the user-visible
   behavior, rather than the implementation.
   -->
   
   Selection runs already advance in row order, so expanding them to batch boundaries does not require sorting the resulting ranges before merging them.
   
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is
   sometimes worth providing a summary of the individual changes in this PR.
   -->
   Expand and merge selected runs in a single pass, removing the redundant sort and intermediate range vector. Use `next_multiple_of` for the end boundary and clarify how overlapping and adjacent ranges are merged.
   
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they
   covered by existing tests, if so identify these tests)?
   
   If this PR claims a performance improvement, please include evidence such as
   benchmark results.
   
   DO NOT simply paste a list of commands ran to verify the code; this is what our
   CI is for and it pollutes the PR. ONLY explain if testing was included with this
   PR, or why it wasn't.
   -->
   
   existing tests case
   
   # Are there any significant user-facing changes?
   
   <!--
   Significant user-facing changes include:
   - Breaking public API change
   - Significant change to existing functionality (e.g. function returns something different)
   
   These need to be explicitly called out to ensure we have proper documentation if
   required and to ensure we follow proper semantic versioning.
   
   DO NOT restate the changes of this PR; if a bug was fixed and already explained
   above, we don't need this to be restated as a user-facing change.
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org