[GitHub] [arrow] zeroshade commented on a diff in pull request #35178: GH-34852: [C++][Go][Java][FlightRPC] Add support for ordered data

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #35178:
URL: https://github.com/apache/arrow/pull/35178#discussion_r1178102333


##########
go/arrow/flight/server.go:
##########
@@ -52,14 +52,9 @@ type (
 	Empty                           = flight.Empty
 )
 
-// FlightService_ServiceDesc is the grpc.ServiceDesc for the FlightService
-// server. It should only be used for direct call of grpc.RegisterService,
-// and not introspected or modified (even as a copy).
-var FlightService_ServiceDesc = flight.FlightService_ServiceDesc
-

Review Comment:
   Interesting, i see that the updated versions for the `Register` method actually takes a `*grpc.Server` which should likely be sufficient to add a flight service to an existing server. So I think this is fine, but we should definitely mark this as a breaking change as a result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org