You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "misaya295 (via GitHub)" <gi...@apache.org> on 2023/11/09 10:05:57 UTC

[PR] [type:test] add unit test for the Discovery module zk [shenyu]

misaya295 opened a new pull request, #5289:
URL: https://github.com/apache/shenyu/pull/5289

   <!-- Describe your PR here; e.g. Fixes #issueNo -->
   about https://github.com/apache/shenyu/issues/5278
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [type:UT] add unit test for the Discovery module zk [shenyu]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5289:
URL: https://github.com/apache/shenyu/pull/5289#issuecomment-1803568685

   ## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#5289](https://app.codecov.io/gh/apache/shenyu/pull/5289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9fa723f) into [master](https://app.codecov.io/gh/apache/shenyu/commit/7c47cee3c4d505d5ab9894158f609965dcbcc5c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7c47cee) will **decrease** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 9fa723f differs from pull request most recent head 71d2885. Consider uploading reports for the commit 71d2885 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5289      +/-   ##
   ============================================
   - Coverage     61.69%   61.62%   -0.07%     
   - Complexity     8777     8786       +9     
   ============================================
     Files          1261     1262       +1     
     Lines         38677    38775      +98     
     Branches       3694     3701       +7     
   ============================================
   + Hits          23863    23897      +34     
   - Misses        12707    12770      +63     
   - Partials       2107     2108       +1     
   ```
   
   
   [see 9 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [type:UT] add unit test for the Discovery module zk [shenyu]

Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5289:
URL: https://github.com/apache/shenyu/pull/5289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org