You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/28 15:45:42 UTC

[GitHub] EAlexRojas opened a new pull request #7588: [FLINK-11419][filesystem] For recovery, wait until lease is revoked before truncate file

EAlexRojas opened a new pull request #7588: [FLINK-11419][filesystem] For recovery, wait until lease is revoked before truncate file
URL: https://github.com/apache/flink/pull/7588
 
 
   ## What is the purpose of the change
   
   This pull request performs the truncate of the hadoop file only after waiting for the lease to be revoked.
   
   ## Brief change log
   - When resuming execution after a failure, wait until lease is revoked before performing truncate on the file.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `testRecoverWithState`, `testRecoverAfterMultiplePersistsState`, etc in AbstractRecoverableWriterTest class.
   
   An additional integration test could be added to test the case when this is used with a StreamingFileSink and simulate a taskmanager failure (?)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services